Skip to content

Commit 566396b

Browse files
committed
Try enabling _GLIBCXX_USE_CXX11_ABI
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
1 parent dee39b9 commit 566396b

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ endif()
2222
# include aoti_run executable
2323
include(runner/aoti.cmake)
2424
if(TARGET aoti_run)
25-
target_link_libraries(aoti_run tokenizers)
25+
target_link_libraries(aoti_run PUBLIC tokenizers)
2626
target_include_directories(aoti_run PUBLIC runner/third-party/tokenizers/include)
2727
endif()

runner/aoti.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ if(Torch_FOUND)
2525
target_compile_options(aoti_run PUBLIC -DUSE_CUDA)
2626
endif()
2727
target_include_directories(aoti_run PRIVATE ${TORCHCHAT_ROOT}/runner)
28-
target_link_libraries(aoti_run "${TORCH_LIBRARIES}" m)
28+
target_link_libraries(aoti_run PUBLIC "${TORCH_LIBRARIES}" m)
2929
set_property(TARGET aoti_run PROPERTY CXX_STANDARD 17)
3030
endif()
3131

torchchat/utils/scripts/build_native.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ popd
9393
if [[ "$TARGET" == "et" ]]; then
9494
cmake -S . -B ./cmake-out -DCMAKE_PREFIX_PATH=`python3 -c 'import torch;print(torch.utils.cmake_prefix_path)'` -DLINK_TORCHAO_OPS="${LINK_TORCHAO_OPS}" -DET_USE_ADAPTIVE_THREADS=ON -DCMAKE_CXX_FLAGS="-D_GLIBCXX_USE_CXX11_ABI=1" -G Ninja
9595
else
96-
cmake -S . -B ./cmake-out -DCMAKE_PREFIX_PATH=`python3 -c 'import torch;print(torch.utils.cmake_prefix_path)'` -DLINK_TORCHAO_OPS="${LINK_TORCHAO_OPS}" -DCMAKE_CXX_FLAGS="-D_GLIBCXX_USE_CXX11_ABI=0" -G Ninja
96+
cmake -S . -B ./cmake-out -DCMAKE_PREFIX_PATH=`python3 -c 'import torch;print(torch.utils.cmake_prefix_path)'` -DLINK_TORCHAO_OPS="${LINK_TORCHAO_OPS}" -DCMAKE_CXX_FLAGS="-D_GLIBCXX_USE_CXX11_ABI=1" -G Ninja
9797
fi
9898
cmake --build ./cmake-out --target "${TARGET}"_run
9999

0 commit comments

Comments
 (0)