Skip to content

Commit f5aa396

Browse files
authored
Fix et runner (#388)
Summary: Removed patch fixes that got in due to merge conflicts Test Plan: CI + local repro Reviewers: Subscribers: Tasks: Tags:
1 parent dcf9be1 commit f5aa396

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

runner-et/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,12 @@ target_link_options_shared_lib(cpuinfo)
6464
if(ANDROID OR APPLE)
6565
target_link_options_shared_lib(executorch)
6666
endif()
67-
target_link_libraries(runner_et PRIVATE
67+
target_link_libraries(run PRIVATE
6868
"$<LINK_LIBRARY:WHOLE_ARCHIVE,${TORCHCHAT_ROOT}/${ET_BUILD_DIR}/src/executorch/${CMAKE_OUT_DIR}/examples/models/llama2/custom_ops/libcustom_ops.a>")
6969

7070
# This one is needed for cpuinfo where it uses android specific log lib
7171
if(ANDROID)
72-
target_link_libraries(runner_et PRIVATE log)
72+
target_link_libraries(run PRIVATE log)
7373
endif()
7474

7575
# Adding target_link_options_shared_lib as commented out below leads to this:

scripts/install_utils.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ clone_executorch() {
3636
git submodule sync
3737
git submodule update --init
3838

39-
echo "Applying fixes"
40-
cp ${TORCHCHAT_ROOT}/scripts/fixes_et/module.cpp ${TORCHCHAT_ROOT}/${ET_BUILD_DIR}/src/executorch/extension/module/module.cpp # ET uses non-standard C++ that does not compile in GCC
41-
cp ${TORCHCHAT_ROOT}/scripts/fixes_et/managed_tensor.h ${TORCHCHAT_ROOT}/${ET_BUILD_DIR}/src/executorch/extension/runner_util/managed_tensor.h # ET is missing headers for vector/memory. This causes downstream issues when building runner-et.
4239
popd
4340
}
4441

0 commit comments

Comments
 (0)