Add gtag() helper function used by star-rating
#2701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally proposed this change in the `pytorch/pytorch_sphinx_theme` repo as PR#188, but SveKars suggested we try it out in `pytorch/tutorials` which does not have as large a scope.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2701
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 382b64c with merge base 17e81c1 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
reviewed
Dec 8, 2023
svekars
reviewed
Dec 8, 2023
svekars
approved these changes
Dec 8, 2023
|
Thanks, @svekars, for catching the issue with the comment markers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally proposed this change in the
pytorch/pytorch_sphinx_themerepo as PR#188, but SveKars suggested we try it out inpytorch/tutorialswhich does not have as large a scope.Fixes #2696
Description
Add JavaScript helper function used by star-rating code...as well as other customer JavaScript in the turtorials.
Checklist