Skip to content

Fix CayleyMap's right_inverse, s/X/A #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2024
Merged

Fix CayleyMap's right_inverse, s/X/A #2765

merged 3 commits into from
Feb 6, 2024

Conversation

afrozenator
Copy link
Contributor

@afrozenator afrozenator commented Feb 4, 2024 •
edited by pytorch-bot bot
Loading

This makes it correct.

Fixes #ISSUE_NUMBER

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @albanD

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2765

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 518d63e with merge base 114320c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars
Copy link
Contributor

svekars commented Feb 5, 2024

@lezcano

@svekars svekars added the core Tutorials of any level of difficulty related to the core pytorch functionality label Feb 5, 2024
lezcano
lezcano approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. We should turn this tutorial into one that is actually run on CI. @svekars could you please do that? I'm happy to review that PR.

@svekars svekars merged commit e96a8a9 into pytorch:main Feb 6, 2024
@svekars svekars mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezcano lezcano lezcano approved these changes

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
cla signed core Tutorials of any level of difficulty related to the core pytorch functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afrozenator @svekars @lezcano @albanD @facebook-github-bot