-
Notifications
You must be signed in to change notification settings - Fork 4.2k
2.4.0 Updates to DCP #2968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4.0 Updates to DCP #2968
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2968
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ed9c46a with merge base 09d6583 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add an item in the recipes_index.rst as well.
https://github.com/wz337/tutorials/blob/main/recipes_source/recipes_index.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editorial suggestions - let me know if you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the editorial change Svetlana suggested, the content looks good to me. Stamping to unblock.
Updated all comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting cleanup. Otherwise, LGTM! Please do not merge until 1 week before the release (July 17).
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Thank you so much for all the editing help! We should add you as an author :) |
Asynchronous Checkpointing Overview | ||
------------------------------------ | ||
Before getting started with Asynchronous Checkpointing, it's important to understand it's differences and limitations as compared to synchronous checkpointing. | ||
Speciically: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling error = "Specifically:"
Description
This PR updates tutorials to include:
Checklist