Skip to content

2.4.0 Updates to DCP #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 22, 2024
Merged

2.4.0 Updates to DCP #2968

merged 17 commits into from
Jul 22, 2024

Conversation

LucasLLC
Copy link
Contributor

@LucasLLC LucasLLC commented Jul 9, 2024

Description

This PR updates tutorials to include:

  • Asynchronous checkpointing examples
  • Updates save examples to include Stateful behavior
  • Adds a note about format utilities

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@LucasLLC LucasLLC requested review from fegin and wz337 July 9, 2024 23:21
@LucasLLC LucasLLC self-assigned this Jul 9, 2024
Copy link

pytorch-bot bot commented Jul 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2968

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ed9c46a with merge base 09d6583 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add an item in the recipes_index.rst as well.
https://github.com/wz337/tutorials/blob/main/recipes_source/recipes_index.rst

@LucasLLC LucasLLC requested a review from wz337 July 10, 2024 13:26
@svekars svekars added the 2.4 label Jul 10, 2024
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial suggestions - let me know if you have any questions.

Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the editorial change Svetlana suggested, the content looks good to me. Stamping to unblock.

@LucasLLC LucasLLC requested review from svekars and fegin July 10, 2024 19:48
@LucasLLC
Copy link
Contributor Author

Updated all comments!

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting cleanup. Otherwise, LGTM! Please do not merge until 1 week before the release (July 17).

@LucasLLC
Copy link
Contributor Author

Formatting cleanup. Otherwise, LGTM! Please do not merge until 1 week before the release (July 17).

Thank you so much for all the editing help! We should add you as an author :)

Asynchronous Checkpointing Overview
------------------------------------
Before getting started with Asynchronous Checkpointing, it's important to understand it's differences and limitations as compared to synchronous checkpointing.
Speciically:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling error = "Specifically:"

@svekars svekars merged commit 7eb547a into main Jul 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants