Skip to content

Commit 0089059

Browse files
committed
use up.settings after up.getOption
1 parent 5e395b9 commit 0089059

File tree

2 files changed

+24
-14
lines changed

2 files changed

+24
-14
lines changed

demo/js/qiniu.js

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,9 +284,11 @@ function QiniuJsSDK() {
284284
};
285285

286286
var getFileKey = function(up, file, func) {
287-
var key = '';
287+
var key = '',
288+
unique_names = false;
288289
if (!op.save_key) {
289-
if (up.getOption('unique_names')) {
290+
unique_names = up.getOption('unique_names') || (up.settings && up.settings.unique_names);
291+
if (unique_names) {
290292
var ext = that.getFileExtension(file.name);
291293
key = ext ? file.id + '.' + ext : file.id;
292294
} else if (typeof func === 'function') {
@@ -313,7 +315,8 @@ function QiniuJsSDK() {
313315
uploader.init();
314316

315317
uploader.bind('FilesAdded', function(up, files) {
316-
if (up.getOption('auto_start')) {
318+
var auto_start = up.getOption('auto_start') || (up.settings && up.settings.auto_start);
319+
if (auto_start) {
317320
$.each(files, function(i, file) {
318321
up.start();
319322
});
@@ -348,7 +351,7 @@ function QiniuJsSDK() {
348351
};
349352

350353

351-
var chunk_size = up.getOption('chunk_size');
354+
var chunk_size = up.getOption('chunk_size') || (up.settings && up.settings.chunk_size);
352355

353356
if (uploader.runtime === 'html5' && chunk_size) {
354357
if (file.size < chunk_size) {
@@ -376,7 +379,8 @@ function QiniuJsSDK() {
376379

377380
ctx = ctx ? ctx + ',' + res.ctx : res.ctx;
378381
var leftSize = info.total - info.offset;
379-
var chunk_size = up.getOption('chunk_size');
382+
var chunk_size = up.getOption('chunk_size') || (up.settings && up.settings.chunk_size);
383+
380384
if (leftSize < chunk_size) {
381385
up.setOption({
382386
'url': 'http://up.qiniu.com/mkblk/' + leftSize
@@ -395,7 +399,8 @@ function QiniuJsSDK() {
395399
errTip = '上传失败。请稍后再试。';
396400
break;
397401
case plupload.FILE_SIZE_ERROR:
398-
errTip = '浏览器最大可上传' + up.getOption('max_file_size') + '。更大文件请使用命令行工具。';
402+
var max_file_size = up.getOption('max_file_size') || (up.settings && up.settings.max_file_size);
403+
errTip = '浏览器最大可上传' + max_file_size + '。更大文件请使用命令行工具。';
399404
break;
400405
case plupload.FILE_EXTENSION_ERROR:
401406
errTip = '文件验证失败。请稍后重试。';
@@ -720,4 +725,4 @@ function QiniuJsSDK() {
720725

721726
}
722727

723-
var Qiniu = new QiniuJsSDK();
728+
var Qiniu = new QiniuJsSDK();

src/qiniu.js

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,9 +284,11 @@ function QiniuJsSDK() {
284284
};
285285

286286
var getFileKey = function(up, file, func) {
287-
var key = '';
287+
var key = '',
288+
unique_names = false;
288289
if (!op.save_key) {
289-
if (up.getOption('unique_names')) {
290+
unique_names = up.getOption('unique_names') || (up.settings && up.settings.unique_names);
291+
if (unique_names) {
290292
var ext = that.getFileExtension(file.name);
291293
key = ext ? file.id + '.' + ext : file.id;
292294
} else if (typeof func === 'function') {
@@ -313,7 +315,8 @@ function QiniuJsSDK() {
313315
uploader.init();
314316

315317
uploader.bind('FilesAdded', function(up, files) {
316-
if (up.getOption('auto_start')) {
318+
var auto_start = up.getOption('auto_start') || (up.settings && up.settings.auto_start);
319+
if (auto_start) {
317320
$.each(files, function(i, file) {
318321
up.start();
319322
});
@@ -348,7 +351,7 @@ function QiniuJsSDK() {
348351
};
349352

350353

351-
var chunk_size = up.getOption('chunk_size');
354+
var chunk_size = up.getOption('chunk_size') || (up.settings && up.settings.chunk_size);
352355

353356
if (uploader.runtime === 'html5' && chunk_size) {
354357
if (file.size < chunk_size) {
@@ -376,7 +379,8 @@ function QiniuJsSDK() {
376379

377380
ctx = ctx ? ctx + ',' + res.ctx : res.ctx;
378381
var leftSize = info.total - info.offset;
379-
var chunk_size = up.getOption('chunk_size');
382+
var chunk_size = up.getOption('chunk_size') || (up.settings && up.settings.chunk_size);
383+
380384
if (leftSize < chunk_size) {
381385
up.setOption({
382386
'url': 'http://up.qiniu.com/mkblk/' + leftSize
@@ -395,7 +399,8 @@ function QiniuJsSDK() {
395399
errTip = '上传失败。请稍后再试。';
396400
break;
397401
case plupload.FILE_SIZE_ERROR:
398-
errTip = '浏览器最大可上传' + up.getOption('max_file_size') + '。更大文件请使用命令行工具。';
402+
var max_file_size = up.getOption('max_file_size') || (up.settings && up.settings.max_file_size);
403+
errTip = '浏览器最大可上传' + max_file_size + '。更大文件请使用命令行工具。';
399404
break;
400405
case plupload.FILE_EXTENSION_ERROR:
401406
errTip = '文件验证失败。请稍后重试。';
@@ -720,4 +725,4 @@ function QiniuJsSDK() {
720725

721726
}
722727

723-
var Qiniu = new QiniuJsSDK();
728+
var Qiniu = new QiniuJsSDK();

0 commit comments

Comments
 (0)