Skip to content

Commit 3d1cda3

Browse files
committed
Merge pull request #96 from qiniu/develop
Release v6.1.2
2 parents 1ee6941 + 75c8995 commit 3d1cda3

File tree

6 files changed

+33
-26
lines changed

6 files changed

+33
-26
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
## CHANGE LOG
22

3+
### v6.1.2
4+
5+
2014-2-17 issue [#96](https://github.com/qiniu/nodejs-sdk/pull/96)
6+
7+
- Content-Length = 0 时的细节修复
8+
9+
310
### v6.1.1
411

512
2013-12-5 issue [#90](https://github.com/qiniu/nodejs-sdk/pull/90)

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
TESTS = test/*.test.js
2-
TIMEOUT = 15000
2+
TIMEOUT = 25000
33
REPORTER = spec
44
MOCHA_OPTS =
55
test:

docs/README.gist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Node.js SDK 主要包含对七牛云存储API的包装,遵循[qiniu sdkspec](h
6969

7070
<sdk安装说明\>
7171
通过 npm 以 node 模块化的方式安装:
72-
`npm node qiniu`
72+
`$ npm install qiniu`
7373

7474
<a name="appkey"></a>
7575

docs/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Node.js SDK 主要包含对七牛云存储API的包装,遵循[qiniu sdkspec](h
6969

7070
<sdk安装说明\>
7171
通过 npm 以 node 模块化的方式安装:
72-
`npm node qiniu`
72+
`$ npm install qiniu`
7373

7474
<a name="appkey"></a>
7575

@@ -533,7 +533,7 @@ qiniu.rsf.listPrefix(bucketname, prefix, marker, limit, function(err, ret) {
533533

534534
```{javascript}
535535
// 生成访问图片的url
536-
var url = qiniu.rs.makeBaseUrl(bucketName, key);
536+
var url = qiniu.rs.makeBaseUrl(domain, key);
537537
538538
// 生成fop_url
539539
var ii = new qiniu.fop.ImageInfo();
@@ -551,7 +551,7 @@ console.log('在浏览器输入: ' + url);
551551

552552
```{javascript}
553553
// 生成访问图片的url
554-
var url = qiniu.rs.makeBaseUrl(bucketName, key);
554+
var url = qiniu.rs.makeBaseUrl(domain, key);
555555
556556
// 生成fop_url
557557
var exif = new qiniu.fop.Exif();
@@ -569,7 +569,7 @@ console.log('在浏览器输入: ' + url);
569569

570570
```{javascript}
571571
// 生成访问图片的url
572-
var url = qiniu.rs.makeBaseUrl(bucketName, key);
572+
var url = qiniu.rs.makeBaseUrl(domain, key);
573573
574574
// 生成fop_url
575575
var iv = new qiniu.fop.ImageView();

docs/gist/fop.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ var qiniu = require('../../');
33
qiniu.conf.ACCESS_KEY = '8Y7uZY0cqHxAyGK27V_B2Bxf8IhAkqEPOHr6iwwc';
44
qiniu.conf.SECRET_KEY = '1uvFVvk9IqFRQ6t4TCr-DdeXybTbSS0gauJrYiJN';
55

6-
var bucketName = 'test369.qiniudn.com';
6+
var domain = 'test369.qiniudn.com';
77
var key = 'logo.png';
88
// @gist makeImageInfoUrl
99
// 生成访问图片的url
10-
var url = qiniu.rs.makeBaseUrl(bucketName, key);
10+
var url = qiniu.rs.makeBaseUrl(domain, key);
1111

1212
// 生成fop_url
1313
var ii = new qiniu.fop.ImageInfo();
@@ -23,7 +23,7 @@ console.log('在浏览器输入: ' + url);
2323

2424
// @gist makeExifUrl
2525
// 生成访问图片的url
26-
var url = qiniu.rs.makeBaseUrl(bucketName, key);
26+
var url = qiniu.rs.makeBaseUrl(domain, key);
2727

2828
// 生成fop_url
2929
var exif = new qiniu.fop.Exif();
@@ -40,7 +40,7 @@ console.log('在浏览器输入: ' + url);
4040
// @gist makeImageViewUrl
4141

4242
// 生成访问图片的url
43-
var url = qiniu.rs.makeBaseUrl(bucketName, key);
43+
var url = qiniu.rs.makeBaseUrl(domain, key);
4444

4545
// 生成fop_url
4646
var iv = new qiniu.fop.ImageView();

qiniu/rpc.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,27 @@ function post(uri, form, headers, onresp) {
3434
headers = headers || {};
3535
headers['User-Agent'] = headers['User-Agent'] || conf.USER_AGENT;
3636

37-
var content = null;
38-
if (Buffer.isBuffer(form) || typeof form === 'string') {
39-
content = form;
40-
form = null;
41-
}
42-
43-
var req = urllib.request(uri, {
37+
var data = {
4438
headers: headers,
4539
method: 'POST',
46-
content: content,
4740
dataType: 'json',
4841
timeout: conf.RPC_TIMEOUT,
49-
}, function (err, result, res) {
50-
if (err) {
51-
err.code = res && res.statusCode || -1;
42+
};
43+
44+
if (Buffer.isBuffer(form) || typeof form === 'string') {
45+
data.content = form;
46+
} else if (form) {
47+
data.stream = form;
48+
} else {
49+
data.headers['Content-Length'] = 0;
50+
};
51+
52+
var req = urllib.request(uri, data, function(err, result, res) {
53+
var rerr = null;
54+
if (err || Math.floor(res.statusCode/100) !== 2) {
55+
rerr = {code: res&&res.statusCode||-1, error: err||result.error||''};
5256
}
53-
onresp(err, result, res);
57+
onresp(rerr, result, res);
5458
});
55-
56-
if (form) {
57-
form.pipe(req);
58-
}
5959
}
6060

0 commit comments

Comments
 (0)