Skip to content

Commit f9645c8

Browse files
committed
tweak comments and tests
- fix an error comment - uncomment some test params for more test cases - ignore ENOENT error when cleanup files after testing
1 parent 8b0d320 commit f9645c8

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

qiniu/httpc/client.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ HttpClient.prototype.sendRequest = function (requestOptions) {
8282
const resPromise = handle(requestOptions);
8383

8484
if (requestOptions.callback) {
85-
// callback error will be chained to result.
85+
// user should handle callback error outside.
86+
// already wrapped callback for inner usage in storage.
8687
resPromise.then(({ data, resp }) => {
8788
requestOptions.callback(null, data, resp);
8889
});

test/form_up.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ after(function () {
3333
testFilePath2
3434
].map(p => new Promise(resolve => {
3535
fs.unlink(p, err => {
36-
if (err) {
36+
if (err && err.code !== 'ENOENT') {
3737
console.log(`unlink ${p} failed`, err);
3838
}
3939
resolve();

test/resume_up.test.js

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ after(function () {
7272
testFilePath
7373
].map(p => new Promise(resolve => {
7474
fs.unlink(p, err => {
75-
if (err) {
75+
if (err && err.code !== 'ENOENT') {
7676
console.log(`unlink ${p} failed`, err);
7777
}
7878
resolve();
@@ -384,22 +384,21 @@ describe('test resume up', function () {
384384
{
385385
name: 'version',
386386
values: [
387-
// undefined,
387+
undefined,
388388
'v1',
389389
'v2'
390390
]
391391
},
392-
// {
393-
// name: 'partSize',
394-
// values: [
395-
// undefined,
396-
// 6 * 1024 * 1024
397-
// ]
398-
// },
392+
{
393+
name: 'partSize',
394+
values: [
395+
undefined,
396+
6 * 1024 * 1024
397+
]
398+
},
399399
{
400400
name: 'fileSizeMB',
401-
// values: [2, 4, 6, 10]
402-
values: [2, 10]
401+
values: [2, 4, 6, 10]
403402
}
404403
);
405404

@@ -408,7 +407,7 @@ describe('test resume up', function () {
408407
return Promise.all(
409408
filepathListToDelete.map(p => new Promise(resolve => {
410409
fs.unlink(p, err => {
411-
if (err) {
410+
if (err && err.code !== 'ENOENT') {
412411
console.log(`unlink ${p} failed`, err);
413412
}
414413
resolve();

0 commit comments

Comments
 (0)