File tree Expand file tree Collapse file tree 3 files changed +14
-14
lines changed Expand file tree Collapse file tree 3 files changed +14
-14
lines changed Original file line number Diff line number Diff line change @@ -82,7 +82,8 @@ HttpClient.prototype.sendRequest = function (requestOptions) {
82
82
const resPromise = handle ( requestOptions ) ;
83
83
84
84
if ( requestOptions . callback ) {
85
- // callback error will be chained to result.
85
+ // user should handle callback error outside.
86
+ // already wrapped callback for inner usage in storage.
86
87
resPromise . then ( ( { data, resp } ) => {
87
88
requestOptions . callback ( null , data , resp ) ;
88
89
} ) ;
Original file line number Diff line number Diff line change @@ -33,7 +33,7 @@ after(function () {
33
33
testFilePath2
34
34
] . map ( p => new Promise ( resolve => {
35
35
fs . unlink ( p , err => {
36
- if ( err ) {
36
+ if ( err && err . code !== 'ENOENT' ) {
37
37
console . log ( `unlink ${ p } failed` , err ) ;
38
38
}
39
39
resolve ( ) ;
Original file line number Diff line number Diff line change @@ -72,7 +72,7 @@ after(function () {
72
72
testFilePath
73
73
] . map ( p => new Promise ( resolve => {
74
74
fs . unlink ( p , err => {
75
- if ( err ) {
75
+ if ( err && err . code !== 'ENOENT' ) {
76
76
console . log ( `unlink ${ p } failed` , err ) ;
77
77
}
78
78
resolve ( ) ;
@@ -384,22 +384,21 @@ describe('test resume up', function () {
384
384
{
385
385
name : 'version' ,
386
386
values : [
387
- // undefined,
387
+ undefined ,
388
388
'v1' ,
389
389
'v2'
390
390
]
391
391
} ,
392
- // {
393
- // name: 'partSize',
394
- // values: [
395
- // undefined,
396
- // 6 * 1024 * 1024
397
- // ]
398
- // },
392
+ {
393
+ name : 'partSize' ,
394
+ values : [
395
+ undefined ,
396
+ 6 * 1024 * 1024
397
+ ]
398
+ } ,
399
399
{
400
400
name : 'fileSizeMB' ,
401
- // values: [2, 4, 6, 10]
402
- values : [ 2 , 10 ]
401
+ values : [ 2 , 4 , 6 , 10 ]
403
402
}
404
403
) ;
405
404
@@ -408,7 +407,7 @@ describe('test resume up', function () {
408
407
return Promise . all (
409
408
filepathListToDelete . map ( p => new Promise ( resolve => {
410
409
fs . unlink ( p , err => {
411
- if ( err ) {
410
+ if ( err && err . code !== 'ENOENT' ) {
412
411
console . log ( `unlink ${ p } failed` , err ) ;
413
412
}
414
413
resolve ( ) ;
You can’t perform that action at this time.
0 commit comments