Skip to content

Commit 1ddc0b4

Browse files
amykhuangstampho
authored andcommitted
[Backport] Fix instances of -Wmissing-template-arg-list-after-template-kw.
Clang has a new warning that requires a template argument list after using the template keyword. Remove uses of the template keyword when we're not specifying types. See llvm/llvm-project#94194 for the upstream clang change. Upstream-Status: Backport [chromium/chromium@b0088fa] Bug: 344680447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5604664 Reviewed-by: Kentaro Hara <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Amy Huang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1311538} Change-Id: Icf1426fb718550346711b332ca658d92f1421064 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/586001 Reviewed-by: Peter Varga <[email protected]> (cherry picked from commit 0916f81) Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/586336 Reviewed-by: Khem Raj <[email protected]> Reviewed-by: Qt Cherry-pick Bot <[email protected]>
1 parent a56377e commit 1ddc0b4

File tree

1 file changed

+4
-4
lines changed
  • chromium/third_party/blink/renderer/platform/wtf

1 file changed

+4
-4
lines changed

chromium/third_party/blink/renderer/platform/wtf/hash_table.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1646,7 +1646,7 @@ HashTable<Key, Value, Extractor, Traits, KeyTraits, Allocator>::ExpandBuffer(
16461646
}
16471647
}
16481648
table_ = temporary_table;
1649-
Allocator::template BackingWriteBarrier(&table_);
1649+
Allocator::BackingWriteBarrier(&table_);
16501650

16511651
HashTableBucketInitializer<Traits, Allocator, Value>::InitializeTable(
16521652
original_table, new_table_size);
@@ -1700,7 +1700,7 @@ Value* HashTable<Key, Value, Extractor, Traits, KeyTraits, Allocator>::RehashTo(
17001700
// This swaps the newly allocated buffer with the current one. The store to
17011701
// the current table has to be atomic to prevent races with concurrent marker.
17021702
AsAtomicPtr(&table_)->store(new_hash_table.table_, std::memory_order_relaxed);
1703-
Allocator::template BackingWriteBarrier(&table_);
1703+
Allocator::BackingWriteBarrier(&table_);
17041704
table_size_ = new_table_size;
17051705

17061706
new_hash_table.table_ = old_table;
@@ -1852,8 +1852,8 @@ void HashTable<Key, Value, Extractor, Traits, KeyTraits, Allocator>::swap(
18521852
// on the mutator thread, which is also the only one that writes to them, so
18531853
// there is *no* risk of data races when reading.
18541854
AtomicWriteSwap(table_, other.table_);
1855-
Allocator::template BackingWriteBarrier(&table_);
1856-
Allocator::template BackingWriteBarrier(&other.table_);
1855+
Allocator::BackingWriteBarrier(&table_);
1856+
Allocator::BackingWriteBarrier(&other.table_);
18571857
if (IsWeak<ValueType>::value) {
18581858
// Weak processing is omitted when no backing store is present. In case such
18591859
// an empty table is later on used it needs to be strongified.

0 commit comments

Comments
 (0)