Use ScreenCaptureKit for macOS 13.2 and later

A stable ScreenCaptureKit support is available starting from macOS
13.2. Due to compilation issues on older macOS version, QtWebEngine
was not using this feature. A gn argument use_sck is added to handle
the compile time version check. This will be set while configuring
the QtWebEngine.

Change-Id: I9112f0bce6292ccb9215821c951d968997ac4367
Task-number: QTBUG-127797
Pick-to: 118-based
Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/585455
Reviewed-by: Martin Negyokru <[email protected]>
Reviewed-by: Allan Sandfeld Jensen <[email protected]>

Author: Anu Aliyas

chromium/content/browser/BUILD.gn

@@ -2818,16 +2818,14 @@ jumbo_source_set("browser") {
       frameworks += [ "CoreMedia.framework" ]
       weak_frameworks += [ "ScreenCaptureKit.framework" ]  # macOS 12.3
 
-      if (is_qtwebengine) {
+      if (!use_sck) {
         sources -= [
           "media/capture/screen_capture_kit_device_mac.h",
           "media/capture/screen_capture_kit_device_mac.mm",
           "media/capture/screen_capture_kit_fullscreen_module.h",
           "media/capture/screen_capture_kit_fullscreen_module.mm",
         ]
-
         weak_frameworks -= [ "ScreenCaptureKit.framework" ]  # macOS 12.3
-
       }
     }
     if (is_chromeos_ash) {

chromium/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc

@@ -48,8 +48,11 @@
 #endif  // BUILDFLAG(ENABLE_WEBRTC)
 #endif  // !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
 #if BUILDFLAG(IS_MAC)
+#include "base/mac/mac_util.h"
 #include "content/browser/media/capture/desktop_capture_device_mac.h"
+#if BUILDFLAG(USE_SCK)
 #include "content/browser/media/capture/screen_capture_kit_device_mac.h"
+#endif // BUILDFLAG(USE_SCK)
 #include "content/browser/media/capture/views_widget_video_capture_device_mac.h"
 #endif
 #if BUILDFLAG(IS_CHROMEOS_LACROS)
@@ -194,7 +197,9 @@ DesktopCaptureImplementation CreatePlatformDependentVideoCaptureDevice(
 #if BUILDFLAG(IS_MAC)
   // Prefer using ScreenCaptureKit. After that try DesktopCaptureDeviceMac, and
   // if both fail, use the generic DesktopCaptureDevice.
-#if !BUILDFLAG(IS_QTWEBENGINE)
+  // Although ScreenCaptureKit is available in 12.3 there were some bugs that
+  // were not fixed until 13.2
+#if BUILDFLAG(USE_SCK)
   // ### Requires macOS sdk 12.3:
   if (base::FeatureList::IsEnabled(kScreenCaptureKitMac) ||
       (desktop_id.type == DesktopMediaID::TYPE_WINDOW &&
@@ -204,7 +209,7 @@ DesktopCaptureImplementation CreatePlatformDependentVideoCaptureDevice(
     if ((device_out = CreateScreenCaptureKitDeviceMac(desktop_id)))
       return kScreenCaptureKitDeviceMac;
   }
-#endif  // !BUILDFLAG(IS_QTWEBENGINE)
+#endif //BUILDFLAG(USE_SCK)
   if ((device_out = CreateDesktopCaptureDeviceMac(desktop_id))) {
     return kDesktopCaptureDeviceMac;
   }

chromium/media/BUILD.gn

@@ -67,6 +67,7 @@ buildflag_header("media_buildflags") {
     "USE_CHROMEOS_PROTECTED_AV1=$use_chromeos_protected_av1",
     "USE_CHROMEOS_PROTECTED_MEDIA=$use_chromeos_protected_media",
     "USE_PROPRIETARY_CODECS=$proprietary_codecs",
+    "USE_SCK=$use_sck",
   ]
 
   if (enable_library_cdms) {

chromium/media/media_options.gni

@@ -129,6 +129,10 @@ declare_args() {
   # Enable inclusion of VVC/H.266 parser/demuxer, and also enable VVC/H.266 decoding
   # with hardware acceleration provided by platform. Disabled by default for all builds.
   enable_platform_vvc = false
+
+  # Enable the use of ScreenCaptureKit framework on macOS. A stable ScreenCaptureKit is available
+  # from macOS 13.2. Enabled by default for all build.
+  use_sck = true
 }
 
 # Use another declare_args() to allow dependence on args defined above.