don't use names in internal data1 data structure

Author: EmilHvitfeldt

R/sparse_character.R

@@ -71,10 +71,10 @@ sparse_character <- function(values, positions, length, default = "") {
 
 new_sparse_character <- function(values, positions, length, default) {
   x <- list(
-    val = values,
-    pos = positions,
-    len = length,
-    default = default
+    values,
+    positions,
+    length,
+    default
   )
 
   .Call(ffi_altrep_new_sparse_string, x)

R/sparse_double.R

@@ -82,10 +82,10 @@ sparse_double <- function(values, positions, length, default = 0) {
 
 new_sparse_double <- function(values, positions, length, default) {
   x <- list(
-    val = values,
-    pos = positions,
-    len = length,
-    default = default
+    values,
+    positions,
+    length,
+    default
   )
 
   .Call(ffi_altrep_new_sparse_double, x)

R/sparse_integer.R

@@ -82,10 +82,10 @@ sparse_integer <- function(values, positions, length, default = 0L) {
 
 new_sparse_integer <- function(values, positions, length, default) {
   x <- list(
-    val = values,
-    pos = positions,
-    len = length,
-    default = default
+    values,
+    positions,
+    length,
+    default
   )
 
   .Call(ffi_altrep_new_sparse_integer, x)

R/sparse_logical.R

@@ -69,10 +69,10 @@ sparse_logical <- function(values, positions, length, default = FALSE) {
 
 new_sparse_logical <- function(values, positions, length, default) {
   x <- list(
-    val = values,
-    pos = positions,
-    len = length,
-    default = default
+    values,
+    positions,
+    length,
+    default
   )
 
   .Call(ffi_altrep_new_sparse_logical, x)

src/altrep-sparse-double.c

@@ -140,13 +140,6 @@ static SEXP altrep_sparse_double_Extract_subset(SEXP x, SEXP indx, SEXP call) {
   SEXP out_default = extract_default(x);
   SET_VECTOR_ELT(out, 3, out_default);
 
-  SEXP names = Rf_allocVector(STRSXP, 4);
-  Rf_setAttrib(out, R_NamesSymbol, names);
-  SET_STRING_ELT(names, 0, Rf_mkChar("val"));
-  SET_STRING_ELT(names, 1, Rf_mkChar("pos"));
-  SET_STRING_ELT(names, 2, Rf_mkChar("len"));
-  SET_STRING_ELT(names, 3, Rf_mkChar("default"));
-
   R_xlen_t i_out = 0;
 
   for (R_xlen_t i = 0; i < size; ++i) {

src/altrep-sparse-integer.c

@@ -140,13 +140,6 @@ static SEXP altrep_sparse_integer_Extract_subset(SEXP x, SEXP indx, SEXP call) {
   SEXP out_default = extract_default(x);
   SET_VECTOR_ELT(out, 3, out_default);
 
-  SEXP names = Rf_allocVector(STRSXP, 4);
-  Rf_setAttrib(out, R_NamesSymbol, names);
-  SET_STRING_ELT(names, 0, Rf_mkChar("val"));
-  SET_STRING_ELT(names, 1, Rf_mkChar("pos"));
-  SET_STRING_ELT(names, 2, Rf_mkChar("len"));
-  SET_STRING_ELT(names, 3, Rf_mkChar("default"));
-
   R_xlen_t i_out = 0;
 
   for (R_xlen_t i = 0; i < size; ++i) {

src/altrep-sparse-logical.c

@@ -140,13 +140,6 @@ static SEXP altrep_sparse_logical_Extract_subset(SEXP x, SEXP indx, SEXP call) {
   SEXP out_default = extract_default(x);
   SET_VECTOR_ELT(out, 3, out_default);
 
-  SEXP names = Rf_allocVector(STRSXP, 4);
-  Rf_setAttrib(out, R_NamesSymbol, names);
-  SET_STRING_ELT(names, 0, Rf_mkChar("val"));
-  SET_STRING_ELT(names, 1, Rf_mkChar("pos"));
-  SET_STRING_ELT(names, 2, Rf_mkChar("len"));
-  SET_STRING_ELT(names, 3, Rf_mkChar("default"));
-
   R_xlen_t i_out = 0;
 
   for (R_xlen_t i = 0; i < size; ++i) {

src/altrep-sparse-string.c

@@ -137,13 +137,6 @@ static SEXP altrep_sparse_string_Extract_subset(SEXP x, SEXP indx, SEXP call) {
   SEXP out_default = extract_default(x);
   SET_VECTOR_ELT(out, 3, out_default);
 
-  SEXP names = Rf_allocVector(STRSXP, 4);
-  Rf_setAttrib(out, R_NamesSymbol, names);
-  SET_STRING_ELT(names, 0, Rf_mkChar("val"));
-  SET_STRING_ELT(names, 1, Rf_mkChar("pos"));
-  SET_STRING_ELT(names, 2, Rf_mkChar("len"));
-  SET_STRING_ELT(names, 3, Rf_mkChar("default"));
-
   R_xlen_t i_out = 0;
 
   for (R_xlen_t i = 0; i < size; ++i) {