Skip to content

Commit 439d434

Browse files
committed
fixup
1 parent e50f6ed commit 439d434

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

RabbitMQ.AMQP.Client/Impl/AmqpManagement.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,8 @@ private void OnManagementSessionClosed(IAmqpObject sender, Amqp.Framing.Error er
142142

143143
OnNewStatus(State.Closed, Utils.ConvertError(error));
144144

145-
// TODO since this method is also called when a connection is force-closed,
146-
// I don't think we want to set this TCS here
147145
// Note: TrySetResult *must* be used here
148-
// _connectionCloseTaskCompletionSource.TrySetResult(true);
146+
_connectionCloseTaskCompletionSource.TrySetResult(true);
149147
}
150148

151149
private async Task ProcessResponses()

RabbitMQ.AMQP.Client/Impl/AmqpPublisher.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,8 @@ void OutcomeCallback(ILink sender, Message message, Outcome outcome, object stat
125125
{
126126
System.Diagnostics.Debug.Assert(Object.ReferenceEquals(this, state));
127127
System.Diagnostics.Debug.Assert(Object.ReferenceEquals(_senderLink, sender));
128-
System.Diagnostics.Debug.Assert(Object.ReferenceEquals(nativeMessage, message));
128+
// Note: sometimes `message` is null 🤔
129+
// System.Diagnostics.Debug.Assert(Object.ReferenceEquals(nativeMessage, message));
129130

130131
OutcomeState publishState = OutcomeState.Accepted;
131132
// TODO what about other outcomes, like Released?

0 commit comments

Comments
 (0)