Major refactor

* Refactor test suites to use `IntegrationTest` base class
* Remove IQueueDeletion and IExchangeDeletion, instead using the appropriate specification to do deletions
* Increase Managment ReceiverLink credit to allow multiple management operations at the same time
* Use `UrlEncode`, otherwise characters like double quotes will not be encoded correctly

* Start poking around at the reconnection code

* Make reconnection logic a bit easier to follow.

* No need for a separate reconnection Task

Minor changes

Signed-off-by: Gabriele Santomaggio <[email protected]>

Enforce naming for protected fields

Author: lukebakken

.editorconfig

@@ -51,21 +51,21 @@ dotnet_naming_symbols.constant_fields.required_modifiers = const
 dotnet_naming_style.pascal_case_style.capitalization = pascal_case
 
 # static fields should have s_ prefix
-dotnet_naming_rule.static_fields_should_have_prefix.severity = suggestion
+dotnet_naming_rule.static_fields_should_have_prefix.severity = warning
 dotnet_naming_rule.static_fields_should_have_prefix.symbols  = static_fields
 dotnet_naming_rule.static_fields_should_have_prefix.style    = static_prefix_style
 dotnet_naming_symbols.static_fields.applicable_kinds   = field
 dotnet_naming_symbols.static_fields.required_modifiers = static
-dotnet_naming_symbols.static_fields.applicable_accessibilities = private, internal, private_protected
+dotnet_naming_symbols.static_fields.applicable_accessibilities = internal, private, private_protected, protected
 dotnet_naming_style.static_prefix_style.required_prefix = s_
 dotnet_naming_style.static_prefix_style.capitalization = camel_case
 
 # internal and private fields should be _camelCase
-dotnet_naming_rule.camel_case_for_private_internal_fields.severity = suggestion
+dotnet_naming_rule.camel_case_for_private_internal_fields.severity = warning
 dotnet_naming_rule.camel_case_for_private_internal_fields.symbols  = private_internal_fields
 dotnet_naming_rule.camel_case_for_private_internal_fields.style    = camel_case_underscore_style
 dotnet_naming_symbols.private_internal_fields.applicable_kinds = field
-dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = private, internal
+dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = internal, private, private_protected, protected
 dotnet_naming_style.camel_case_underscore_style.required_prefix = _
 dotnet_naming_style.camel_case_underscore_style.capitalization = camel_case
 

Tests/IntegrationTest.cs

@@ -36,11 +36,11 @@ public IntegrationTest(ITestOutputHelper testOutputHelper,
         _queueName = $"{_testDisplayName}-queue-{Now}";
         _exchangeName = $"{_testDisplayName}-exchange-{Now}";
 
-        Type testOutputHelperType = _testOutputHelper.GetType();
+        Type testOutputHelperType = testOutputHelper.GetType();
         FieldInfo? testMember = testOutputHelperType.GetField("test", BindingFlags.Instance | BindingFlags.NonPublic);
         if (testMember is not null)
         {
-            object? testObj = testMember.GetValue(_testOutputHelper);
+            object? testObj = testMember.GetValue(testOutputHelper);
             if (testObj is ITest test)
             {
                 _testDisplayName = test.DisplayName;

Tests/Recovery/PublisherConsumerRecoveryTests.cs

@@ -30,7 +30,7 @@ public async Task ProducerShouldChangeStatusWhenClosed()
         IPublisher publisher = await _connection.PublisherBuilder().Queue(queueSpec).BuildAsync();
 
         List<(State, State)> states = [];
-        publisher.ChangeState += (sender, fromState, toState, e) =>
+        publisher.ChangeState += (_, fromState, toState, _) =>
         {
             states.Add((fromState, toState));
         };
@@ -68,8 +68,9 @@ public async Task ConsumerShouldChangeStatusWhenClosed()
                 return Task.CompletedTask;
             }).BuildAsync();
 
+
         List<(State, State)> states = [];
-        consumer.ChangeState += (sender, fromState, toState, e) =>
+        consumer.ChangeState += (_, fromState, toState, _) =>
         {
             states.Add((fromState, toState));
         };
@@ -109,7 +110,7 @@ public async Task ProducerShouldChangeStatusWhenConnectionIsKilled()
             .BuildAsync();
 
         List<(State, State)> states = [];
-        publisher.ChangeState += (sender, fromState, toState, e) =>
+        publisher.ChangeState += (_, fromState, toState, _) =>
         {
             states.Add((fromState, toState));
         };
@@ -156,7 +157,7 @@ public async Task ConsumerShouldChangeStatusWhenConnectionIsKilled()
             }).BuildAsync();
 
         List<(State, State)> states = [];
-        consumer.ChangeState += (sender, fromState, toState, e) => { states.Add((fromState, toState)); };
+        consumer.ChangeState += (_, fromState, toState, _) => { states.Add((fromState, toState)); };
 
         await SystemUtils.WaitUntilConnectionIsKilledAndOpen(_containerId);
 
@@ -194,7 +195,7 @@ public async Task PublishShouldRestartPublishConsumerShouldRestartConsumeWhenCon
         long messagesReceived = 0;
 
         IConsumer consumer = await _connection.ConsumerBuilder().InitialCredits(100).Queue(queueSpec)
-            .MessageHandler(async (context, message) =>
+            .MessageHandler(async (context, _) =>
             {
                 Interlocked.Increment(ref messagesReceived);
                 try
@@ -289,15 +290,15 @@ public async Task PublisherAndConsumerShouldNotRestartIfRecoveryIsDisabled()
         IPublisher publisher = await _connection.PublisherBuilder().Queue(queueSpec).BuildAsync();
 
         List<(State, State)> statesProducer = [];
-        publisher.ChangeState += (sender, fromState, toState, e) =>
+        publisher.ChangeState += (_, fromState, toState, _) =>
         {
             statesProducer.Add((fromState, toState));
         };
 
         IConsumer consumer = await _connection.ConsumerBuilder()
             .InitialCredits(100)
             .Queue(queueSpec)
-            .MessageHandler(async (context, message) =>
+            .MessageHandler(async (context, _) =>
             {
                 try
                 {
@@ -310,7 +311,7 @@ public async Task PublisherAndConsumerShouldNotRestartIfRecoveryIsDisabled()
             }).BuildAsync();
 
         List<(State, State)> statesConsumer = [];
-        consumer.ChangeState += (sender, fromState, toState, e) =>
+        consumer.ChangeState += (_, fromState, toState, _) =>
         {
             statesConsumer.Add((fromState, toState));
         };