Rename Exception and and more status

Signed-off-by: Gabriele Santomaggio <[email protected]>

Author: Gsantomaggio

RabbitMQ.AMQP.Client/Impl/AbstractLifeCycle.cs

@@ -2,7 +2,7 @@
 
 namespace RabbitMQ.AMQP.Client.Impl;
 
-public class AmqpClosedException(string message) : Exception(message);
+public class AmqpNotOpenException(string message) : Exception(message);
 
 public abstract class AbstractLifeCycle : ILifeCycle
 {
@@ -18,9 +18,18 @@ protected virtual Task OpenAsync()
 
     protected void ThrowIfClosed()
     {
-        if (State == State.Closed)
+        switch (State)
         {
-            throw new AmqpClosedException(GetType().Name);
+            case State.Closed:
+                throw new AmqpNotOpenException("Resource is closed");
+            case State.Closing:
+                throw new AmqpNotOpenException("Resource is closing");
+            case State.Reconnecting:
+                throw new AmqpNotOpenException("Resource is Reconnecting");
+            case State.Open:
+                break;
+            default:
+                throw new ArgumentOutOfRangeException();
         }
     }
 

Tests/ConnectionTests.cs

@@ -79,7 +79,7 @@ public async Task ThrowAmqpClosedExceptionWhenItemIsClosed()
         await management.Queue().Name("ThrowAmqpClosedExceptionWhenItemIsClosed").Declare();
         var publisher = connection.PublisherBuilder().Queue("ThrowAmqpClosedExceptionWhenItemIsClosed").Build();
         await publisher.CloseAsync();
-        await Assert.ThrowsAsync<AmqpClosedException>(async () =>
+        await Assert.ThrowsAsync<AmqpNotOpenException>(async () =>
             await publisher.Publish(new AmqpMessage("Hello wold!"), (message, descriptor) =>
             {
                 // it doest matter
@@ -88,10 +88,10 @@ await publisher.Publish(new AmqpMessage("Hello wold!"), (message, descriptor) =>
         await connection.CloseAsync();
         Assert.Empty(connection.GetPublishers());
 
-        Assert.Throws<AmqpClosedException>(() =>
+        Assert.Throws<AmqpNotOpenException>(() =>
             connection.PublisherBuilder().Queue("ThrowAmqpClosedExceptionWhenItemIsClosed").Build());
 
-        await Assert.ThrowsAsync<AmqpClosedException>(async () =>
+        await Assert.ThrowsAsync<AmqpNotOpenException>(async () =>
             await management.Queue().Name("ThrowAmqpClosedExceptionWhenItemIsClosed").Declare());
     }
 }

Tests/ManagementTests.cs

@@ -115,7 +115,7 @@ await management.Request(messageId, "", "", "",
     public async Task RaiseManagementClosedException()
     {
         var management = new TestAmqpManagement(null);
-        await Assert.ThrowsAsync<AmqpClosedException>(async () =>
+        await Assert.ThrowsAsync<AmqpNotOpenException>(async () =>
             await management.Request(new Message(), [200]));
         Assert.Equal(State.Closed, management.State);
     }