Merge pull request #32 from rabbitmq/rabbitmq-amqp-dotnet-client-31

Add strong naming to assembly

Author: lukebakken

.github/workflows/build-test.yaml

@@ -28,7 +28,7 @@ jobs:
         id: start-rabbitmq
         run: ${{ github.workspace }}/.ci/ubuntu/gha-setup.sh toxiproxy
       - name: Test
-        run: dotnet test ${{ github.workspace }}/Build.csproj --no-restore --no-build --logger "console;verbosity=detailed" /p:AltCover=true
+        run: dotnet test ${{ github.workspace }}/Build.csproj --no-restore --no-build --logger "console;verbosity=detailed" /p:AltCover=true /p:AltCoverStrongNameKey=${{github.workspace}}/rabbit.snk
       - name: Check for errors in RabbitMQ logs
         run: ${{ github.workspace}}/.ci/ubuntu/gha-log-check.sh
       - name: Maybe collect toxiproxy logs

Directory.Build.targets

@@ -1,5 +1,9 @@
 <!-- vim: set ft=xml: -->
 <Project>
+  <PropertyGroup>
+    <PublicKey>00240000048000009400000006020000002400005253413100040000010001005d8c30a2f8706bf952e03a51ced8b44b6e13c8a643db9ef030032b25431ec6e67b73c570beae14d63e6bd36f248c51800525e33a3fd7749bb877cfac0ad0b6544c9b385c007efb1b283327e6284396807be6300c13bbd14fed3d4c878dc33d1d832303daa9799a7f90e79aa2e5ded80143361e4849879b19a3886544780bb3bc</PublicKey>
+    <TargetFrameworkMonikerAssemblyAttributesPath>$([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)'))</TargetFrameworkMonikerAssemblyAttributesPath>    
+  </PropertyGroup>
   <ItemGroup>
     <EmbeddedFiles Include="$(GeneratedAssemblyInfoFile)"/>
   </ItemGroup>

Makefile

@@ -7,7 +7,7 @@ build:
 	dotnet build $(CURDIR)/Build.csproj
 
 test: build
-	dotnet test -c Debug $(CURDIR)/Tests/Tests.csproj --no-build --logger:"console;verbosity=detailed" /p:AltCover=true
+	dotnet test -c Debug $(CURDIR)/Tests/Tests.csproj --no-build --logger:"console;verbosity=detailed" /p:AltCover=true /p:AltCoverStrongNameKey=$(CURDIR)/rabbit.snk
 
 rabbitmq-server-start-arm:
 	 ./.ci/ubuntu/gha-setup.sh start pull arm 

RabbitMQ.AMQP.Client/RabbitMQ.AMQP.Client.csproj

@@ -15,6 +15,7 @@
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <PackageOutputPath>../packages</PackageOutputPath>
     <PackageReadmeFile>README.md</PackageReadmeFile>
+    <SignAssembly>True</SignAssembly>
   </PropertyGroup>
 
   <ItemGroup>

Tests/Tests.csproj

@@ -6,6 +6,7 @@
     <IsTestProject>true</IsTestProject>
     <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
     <Nullable>enable</Nullable>
+    <SignAssembly>True</SignAssembly>
   </PropertyGroup>
 
   <ItemGroup>

build.ps1

@@ -22,7 +22,7 @@ Write-Host "Done building." -ForegroundColor "Green"
 
 if ($RunTests) {
     Write-Host "Running tests: Build.csproj traversal (all frameworks)" -ForegroundColor "Magenta"
-    dotnet test $build_csproj_file --no-build --logger 'console;verbosity=detailed' '/p:AltCover=true'
+    dotnet test $build_csproj_file --no-build --logger 'console;verbosity=detailed' '/p:AltCover=true' "/p:AltCoverStrongNameKey=$PSScriptRoot/rabbit.snk"
     if ($LastExitCode -ne 0)
     {
         Write-Host "Error with tests, aborting build." -Foreground "Red"