* Fix connection recovery tests to use new virtual Delay method.

Author: lukebakken

RabbitMQ.AMQP.Client/PublicAPI.Unshipped.txt

@@ -39,7 +39,6 @@ RabbitMQ.AMQP.Client.BackOffDelayPolicy
 RabbitMQ.AMQP.Client.BackOffDelayPolicy.BackOffDelayPolicy() -> void
 RabbitMQ.AMQP.Client.BackOffDelayPolicy.BackOffDelayPolicy(int maxAttempt) -> void
 RabbitMQ.AMQP.Client.BackOffDelayPolicy.CurrentAttempt.get -> int
-RabbitMQ.AMQP.Client.BackOffDelayPolicy.Delay() -> int
 RabbitMQ.AMQP.Client.BackOffDelayPolicy.IsActive() -> bool
 RabbitMQ.AMQP.Client.BackOffDelayPolicy.Reset() -> void
 RabbitMQ.AMQP.Client.BadRequestException
@@ -748,5 +747,6 @@ static RabbitMQ.AMQP.Client.InternalBugException.CreateAndThrow(string! message)
 static readonly RabbitMQ.AMQP.Client.SaslMechanism.Anonymous -> RabbitMQ.AMQP.Client.SaslMechanism!
 static readonly RabbitMQ.AMQP.Client.SaslMechanism.External -> RabbitMQ.AMQP.Client.SaslMechanism!
 static readonly RabbitMQ.AMQP.Client.SaslMechanism.Plain -> RabbitMQ.AMQP.Client.SaslMechanism!
+virtual RabbitMQ.AMQP.Client.BackOffDelayPolicy.Delay() -> int
 virtual RabbitMQ.AMQP.Client.Impl.AbstractLifeCycle.Dispose(bool disposing) -> void
 virtual RabbitMQ.AMQP.Client.Impl.AbstractLifeCycle.OpenAsync() -> System.Threading.Tasks.Task!

RabbitMQ.AMQP.Client/RecoveryConfiguration.cs

@@ -105,7 +105,7 @@ public BackOffDelayPolicy(int maxAttempt)
         /// Get the next delay in milliseconds.
         /// </summary>
         /// <returns></returns>
-        public int Delay()
+        public virtual int Delay()
         {
             _attempt++;
             CurrentAttempt++;

Tests/ConnectionRecoveryTests.cs

@@ -15,32 +15,22 @@ namespace Tests;
 
 internal class FakeBackOffDelayPolicyDisabled : BackOffDelayPolicy
 {
-    public new int Delay()
+    public FakeBackOffDelayPolicyDisabled() : base(0)
     {
-        return 1;
     }
 
-    public new void Reset()
+    public override int Delay()
     {
+        return 1;
     }
-
-    public new bool IsActive() => false;
-    public new int CurrentAttempt => 1;
 }
 
 internal class FakeFastBackOffDelay : BackOffDelayPolicy
 {
-    public new int Delay()
+    public override int Delay()
     {
         return 200;
     }
-
-    public new void Reset()
-    {
-    }
-
-    public new bool IsActive() => true;
-    public new int CurrentAttempt => 1;
 }
 
 public class ConnectionRecoveryTests(ITestOutputHelper testOutputHelper)
@@ -189,14 +179,16 @@ public async Task OverrideTheBackOffWithBackOffDisabled()
         Assert.Null(_connection);
         Assert.Null(_management);
 
+        var backoffDelayPolicy = new FakeBackOffDelayPolicyDisabled();
         var recoveryConfiguration = new RecoveryConfiguration();
         recoveryConfiguration.Activated(true);
         recoveryConfiguration.Topology(false);
-        recoveryConfiguration.BackOffDelayPolicy(new FakeBackOffDelayPolicyDisabled());
+        recoveryConfiguration.BackOffDelayPolicy(backoffDelayPolicy);
 
         IConnection connection = await AmqpConnection.CreateAsync(
-            ConnectionSettingsBuilder.Create().ContainerId(_containerId).RecoveryConfiguration(
-                recoveryConfiguration).Build());
+            ConnectionSettingsBuilder.Create()
+            .ContainerId(_containerId)
+            .RecoveryConfiguration(recoveryConfiguration).Build());
 
         var listFromStatus = new List<State>();
         TaskCompletionSource<bool> listFromStatusCountGreaterOrEqualToTwo = CreateTaskCompletionSource<bool>();