Skip to content

Commit d8d8c43

Browse files
committed
Remove AltCover, we are not using the results
1 parent de3df6a commit d8d8c43

File tree

7 files changed

+15
-11
lines changed

7 files changed

+15
-11
lines changed

.github/workflows/build-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
run: ${{ github.workspace }}/.ci/ubuntu/gha-setup.sh
6666
- name: Test
6767
timeout-minutes: 15
68-
run: dotnet test ${{ github.workspace }}/Build.csproj --no-restore --no-build --logger "console;verbosity=detailed" /p:AltCover=true /p:AltCoverStrongNameKey=${{github.workspace}}/rabbit.snk
68+
run: dotnet test ${{ github.workspace }}/Build.csproj --no-restore --no-build --logger "console;verbosity=detailed"
6969
- name: Check for errors in RabbitMQ logs
7070
run: ${{ github.workspace}}/.ci/ubuntu/gha-log-check.sh
7171
- name: Maybe upload RabbitMQ logs

Directory.Packages.props

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,19 @@
22
<PropertyGroup>
33
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
44
</PropertyGroup>
5+
56
<ItemGroup>
67
<!-- RabbitMQ.Amqp.Client -->
78
<PackageVersion Include="AMQPNetLite.Core" Version="2.4.11" />
89
<!-- Tests -->
9-
<PackageVersion Include="AltCover" Version="8.9.3" />
1010
<PackageVersion Include="xunit" Version="2.9.0" />
1111
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
1212
<PackageVersion Include="Xunit.SkippableFact" Version="1.4.13" />
1313
<PackageVersion Include="coverlet.collector" Version="6.0.2" />
1414
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
1515
<PackageVersion Include="EasyNetQ.Management.Client" Version="3.0.0" />
1616
</ItemGroup>
17+
1718
<ItemGroup Condition="$(TargetFramework)=='netstandard2.0'">
1819
<!--
1920
Note: do NOT upgrade these dependencies unless necessary
@@ -24,15 +25,19 @@
2425
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
2526
<PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
2627
</ItemGroup>
28+
2729
<ItemGroup Condition="'$(TargetFramework)'=='net6.0'">
2830
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
2931
</ItemGroup>
32+
3033
<ItemGroup Condition="'$(TargetFramework)'=='net8.0'">
3134
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="8.0.1" />
3235
</ItemGroup>
36+
3337
<ItemGroup Condition="'$(TargetFrameworkIdentifier)'=='.NETFramework'">
3438
<GlobalPackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
3539
</ItemGroup>
40+
3641
<ItemGroup Condition="'$(IsPackable)'=='true'">
3742
<GlobalPackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4" />
3843
<GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ build:
77
dotnet build $(CURDIR)/Build.csproj
88

99
test: build
10-
dotnet test -c Debug $(CURDIR)/Tests/Tests.csproj --no-build --logger:"console;verbosity=detailed" /p:AltCover=true /p:AltCoverStrongNameKey=$(CURDIR)/rabbit.snk
10+
dotnet test -c Debug $(CURDIR)/Tests/Tests.csproj --no-build --logger:"console;verbosity=detailed"
1111

1212
rabbitmq-server-start-arm:
1313
./.ci/ubuntu/gha-setup.sh start pull arm

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ This library is in early stages of development. It is meant to be used with Rabb
55
## How to Run
66

77
- Start the broker with `./.ci/ubuntu/gha-setup.sh start`. Note that this has been tested on Ubuntu 22 with docker.
8-
- Run the tests with ` dotnet test ./Build.csproj --logger "console;verbosity=detailed" /p:AltCover=true`
8+
- Run the tests with ` dotnet test ./Build.csproj --logger "console;verbosity=detailed"`
99
- Stop RabbitMQ with `./.ci/ubuntu/gha-setup.sh stop`
1010

1111
## Getting Started

Tests/Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
</PropertyGroup>
1818

1919
<ItemGroup>
20-
<PackageReference Include="AltCover" />
2120
<PackageReference Include="EasyNetQ.Management.Client" />
2221
<PackageReference Include="Microsoft.NET.Test.Sdk" />
2322
<PackageReference Include="xunit" />

build.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Write-Host "Done building." -ForegroundColor "Green"
2222

2323
if ($RunTests) {
2424
Write-Host "Running tests: Build.csproj traversal (all frameworks)" -ForegroundColor "Magenta"
25-
dotnet test $build_csproj_file --no-build --logger 'console;verbosity=detailed' '/p:AltCover=true' "/p:AltCoverStrongNameKey=$PSScriptRoot/rabbit.snk"
25+
dotnet test $build_csproj_file --no-build --logger 'console;verbosity=detailed'
2626
if ($LastExitCode -ne 0)
2727
{
2828
Write-Host "Error with tests, aborting build." -Foreground "Red"

rabbitmq-amqp-dotnet-client.sln

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ Microsoft Visual Studio Solution File, Format Version 12.00
33
# Visual Studio Version 17
44
VisualStudioVersion = 17.10.35013.160
55
MinimumVisualStudioVersion = 10.0.40219.1
6-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RabbitMQ.AMQP.Client", "RabbitMQ.AMQP.Client\RabbitMQ.AMQP.Client.csproj", "{25FDE562-7B19-422E-A928-C34EC1A5A926}"
6+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RabbitMQ.AMQP.Client", "RabbitMQ.AMQP.Client/RabbitMQ.AMQP.Client.csproj", "{25FDE562-7B19-422E-A928-C34EC1A5A926}"
77
EndProject
8-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tests", "Tests\Tests.csproj", "{A10086DA-3583-4590-BE86-43EAE3852FB4}"
8+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tests", "Tests/Tests.csproj", "{A10086DA-3583-4590-BE86-43EAE3852FB4}"
99
EndProject
10-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GettingStarted", "docs\Examples\GettingStarted\GettingStarted.csproj", "{C0160E0C-C82F-411F-8CFC-D6B53DCF4400}"
10+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GettingStarted", "docs/Examples/GettingStarted/GettingStarted.csproj", "{C0160E0C-C82F-411F-8CFC-D6B53DCF4400}"
1111
EndProject
1212
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{9A316218-49D6-42B4-A64C-8B52AD8C9E4F}"
1313
ProjectSection(SolutionItems) = preProject
@@ -19,9 +19,9 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
1919
README.md = README.md
2020
EndProjectSection
2121
EndProject
22-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PerformanceTest", "docs\Examples\PerformanceTest\PerformanceTest.csproj", "{F9D06630-0B10-41A7-84CB-81FA948CCE54}"
22+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PerformanceTest", "docs/Examples/PerformanceTest/PerformanceTest.csproj", "{F9D06630-0B10-41A7-84CB-81FA948CCE54}"
2323
EndProject
24-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "HAClient", "docs\Examples\HAClient\HAClient.csproj", "{E2FBE920-8DAB-4B52-87AF-B781BF715A5A}"
24+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "HAClient", "docs/Examples/HAClient/HAClient.csproj", "{E2FBE920-8DAB-4B52-87AF-B781BF715A5A}"
2525
EndProject
2626
Global
2727
GlobalSection(SolutionConfigurationPlatforms) = preSolution

0 commit comments

Comments
 (0)