Remove AltCover, we are not using the results

Author: lukebakken

.github/workflows/build-test.yaml

@@ -65,7 +65,7 @@ jobs:
         run: ${{ github.workspace }}/.ci/ubuntu/gha-setup.sh
       - name: Test
         timeout-minutes: 15
-        run: dotnet test ${{ github.workspace }}/Build.csproj --no-restore --no-build --logger "console;verbosity=detailed" /p:AltCover=true /p:AltCoverStrongNameKey=${{github.workspace}}/rabbit.snk
+        run: dotnet test ${{ github.workspace }}/Build.csproj --no-restore --no-build --logger "console;verbosity=detailed"
       - name: Check for errors in RabbitMQ logs
         run: ${{ github.workspace}}/.ci/ubuntu/gha-log-check.sh
       - name: Maybe upload RabbitMQ logs

Directory.Packages.props

@@ -2,18 +2,19 @@
   <PropertyGroup>
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
   </PropertyGroup>
+
   <ItemGroup>
     <!-- RabbitMQ.Amqp.Client -->
     <PackageVersion Include="AMQPNetLite.Core" Version="2.4.11" />
     <!-- Tests -->
-    <PackageVersion Include="AltCover" Version="8.9.3" />
     <PackageVersion Include="xunit" Version="2.9.0" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
     <PackageVersion Include="Xunit.SkippableFact" Version="1.4.13" />
     <PackageVersion Include="coverlet.collector" Version="6.0.2" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
     <PackageVersion Include="EasyNetQ.Management.Client" Version="3.0.0" />
   </ItemGroup>
+
   <ItemGroup Condition="$(TargetFramework)=='netstandard2.0'">
     <!--
       Note: do NOT upgrade these dependencies unless necessary
@@ -24,15 +25,19 @@
     <PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
     <PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
   </ItemGroup>
+
   <ItemGroup Condition="'$(TargetFramework)'=='net6.0'">
     <PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
   </ItemGroup>
+
   <ItemGroup Condition="'$(TargetFramework)'=='net8.0'">
     <PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="8.0.1" />
   </ItemGroup>
+
   <ItemGroup Condition="'$(TargetFrameworkIdentifier)'=='.NETFramework'">
     <GlobalPackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />
   </ItemGroup>
+
   <ItemGroup Condition="'$(IsPackable)'=='true'">
     <GlobalPackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4" />
     <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />

Makefile

@@ -7,7 +7,7 @@ build:
 	dotnet build $(CURDIR)/Build.csproj
 
 test: build
-	dotnet test -c Debug $(CURDIR)/Tests/Tests.csproj --no-build --logger:"console;verbosity=detailed" /p:AltCover=true /p:AltCoverStrongNameKey=$(CURDIR)/rabbit.snk
+	dotnet test -c Debug $(CURDIR)/Tests/Tests.csproj --no-build --logger:"console;verbosity=detailed"
 
 rabbitmq-server-start-arm:
 	 ./.ci/ubuntu/gha-setup.sh start pull arm 

README.md

@@ -5,7 +5,7 @@ This library is in early stages of development. It is meant to be used with Rabb
 ## How to Run
 
 - Start the broker with `./.ci/ubuntu/gha-setup.sh start`. Note that this has been tested on Ubuntu 22 with docker.
-- Run the tests with ` dotnet test ./Build.csproj  --logger "console;verbosity=detailed" /p:AltCover=true`
+- Run the tests with ` dotnet test ./Build.csproj  --logger "console;verbosity=detailed"`
 - Stop RabbitMQ with `./.ci/ubuntu/gha-setup.sh stop`
 
 ## Getting Started

Tests/Tests.csproj

@@ -17,7 +17,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="AltCover" />
     <PackageReference Include="EasyNetQ.Management.Client" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
     <PackageReference Include="xunit" />

build.ps1

@@ -22,7 +22,7 @@ Write-Host "Done building." -ForegroundColor "Green"
 
 if ($RunTests) {
     Write-Host "Running tests: Build.csproj traversal (all frameworks)" -ForegroundColor "Magenta"
-    dotnet test $build_csproj_file --no-build --logger 'console;verbosity=detailed' '/p:AltCover=true' "/p:AltCoverStrongNameKey=$PSScriptRoot/rabbit.snk"
+    dotnet test $build_csproj_file --no-build --logger 'console;verbosity=detailed'
     if ($LastExitCode -ne 0)
     {
         Write-Host "Error with tests, aborting build." -Foreground "Red"