Test non-ASCII characters in entity names

Author: acogoluegnes

src/main/qpid/org/apache/qpid/protonj2/codec/decoders/ProtonDecoderState.java

@@ -128,7 +128,7 @@ private static String internalDecodeUTF8(final ProtonBuffer buffer, final int le
 
         // Create a buffer from the remaining portion of the buffer and then use the decoder to complete the work
         // remember to move the main buffer position to consume the data processed.
-        ByteBuffer byteBuffer = ByteBuffer.allocate(buffer.getReadableBytes());
+        ByteBuffer byteBuffer = ByteBuffer.allocate(length - offset);
 
         buffer.copyInto(buffer.getReadOffset(), byteBuffer, 0, length - offset);
         buffer.advanceReadOffset(length - offset);

src/test/java/com/rabbitmq/client/amqp/impl/AmqpTest.java

@@ -44,6 +44,7 @@
 import org.junit.jupiter.api.*;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
 import org.junit.jupiter.params.provider.ValueSource;
 
 @ExtendWith(AmqpTestInfrastructureExtension.class)
@@ -79,8 +80,9 @@ void queueInfoTest() {
     }
   }
 
-  @Test
-  void queueDeclareDeletePublishConsume() {
+  @ParameterizedTest
+  @ValueSource(strings = {"foobar", "фообар"})
+  void queueDeclareDeletePublishConsume(String subject) {
     try {
       connection.management().queue().name(name).quorum().queue().declare();
       Publisher publisher = connection.publisherBuilder().queue(name).build();
@@ -92,7 +94,10 @@ void queueDeclareDeletePublishConsume() {
               ignored -> {
                 UUID messageId = UUID.randomUUID();
                 publisher.publish(
-                    publisher.message("hello".getBytes(UTF_8)).messageId(messageId),
+                    publisher
+                        .message("hello".getBytes(UTF_8))
+                        .messageId(messageId)
+                        .subject(subject),
                     acceptedCallback(confirmSync));
               });
 
@@ -101,18 +106,21 @@ void queueDeclareDeletePublishConsume() {
       Management.QueueInfo queueInfo = connection.management().queueInfo(name);
       assertThat(queueInfo).hasName(name).hasNoConsumers().hasMessageCount(messageCount);
 
+      AtomicReference<String> receivedSubject = new AtomicReference<>();
       CountDownLatch consumeLatch = new CountDownLatch(messageCount);
       com.rabbitmq.client.amqp.Consumer consumer =
           connection
               .consumerBuilder()
               .queue(name)
               .messageHandler(
                   (context, message) -> {
+                    receivedSubject.set(message.subject());
                     context.accept();
                     consumeLatch.countDown();
                   })
               .build();
       Assertions.assertThat(consumeLatch).is(completed());
+      assertThat(receivedSubject).doesNotHaveNullValue().hasValue(subject);
 
       queueInfo = connection.management().queueInfo(name);
       assertThat(queueInfo).hasConsumerCount(1).isEmpty();
@@ -125,12 +133,17 @@ void queueDeclareDeletePublishConsume() {
   }
 
   @ParameterizedTest
-  @ValueSource(booleans = {false, true})
-  void binding(boolean addBindingArguments, TestInfo info) {
-    String e1 = TestUtils.name(info);
-    String e2 = TestUtils.name(info);
-    String q = TestUtils.name(info);
-    String rk = "foo";
+  @CsvSource({
+    "foo,false",
+    "foo,true",
+    "фообар,true",
+    "фообар,false",
+  })
+  void binding(String prefix, boolean addBindingArguments, TestInfo info) {
+    String e1 = prefix + "-" + TestUtils.name(info);
+    String e2 = prefix + "-" + TestUtils.name(info);
+    String q = prefix + "-" + TestUtils.name(info);
+    String rk = prefix + "-" + "foo";
     Map<String, Object> bindingArguments =
         addBindingArguments ? singletonMap("foo", "bar") : emptyMap();
     Management management = connection.management();