Skip to content

Commit 4890057

Browse files
committed
Update address format v2
References rabbitmq/rabbitmq-server#11618
1 parent c67f95d commit 4890057

File tree

7 files changed

+30
-29
lines changed

7 files changed

+30
-29
lines changed

src/docs/asciidoc/usage.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,21 +65,21 @@ include::{test-examples}/Api.java[tag=message-publishing]
6565
--------
6666
include::{test-examples}/Api.java[tag=target-address-exchange-key]
6767
--------
68-
<1> Translates to `/e/foo/bar`
68+
<1> Translates to `/exchanges/foo/bar`
6969

7070
.Target address format: exchange
7171
[source,java,indent=0]
7272
--------
7373
include::{test-examples}/Api.java[tag=target-address-exchange]
7474
--------
75-
<1> Translates to `/e/foo`
75+
<1> Translates to `/exchanges/foo`
7676

7777
.Target address format: queue
7878
[source,java,indent=0]
7979
--------
8080
include::{test-examples}/Api.java[tag=target-address-queue]
8181
--------
82-
<1> Translates to `/q/some-queue`
82+
<1> Translates to `/queues/some-queue`
8383

8484
.Target address format: address in `to` field
8585
[source,java,indent=0]

src/main/java/com/rabbitmq/client/amqp/impl/DefaultAddressBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,12 @@ public T queue(String queue) {
5959
String address() {
6060
if (this.exchange != null) {
6161
if (this.key != null && !this.key.isEmpty()) {
62-
return "/e/" + encodePathSegment(this.exchange) + "/" + encodePathSegment(this.key);
62+
return "/exchanges/" + encodePathSegment(this.exchange) + "/" + encodePathSegment(this.key);
6363
} else {
64-
return "/e/" + encodePathSegment(this.exchange);
64+
return "/exchanges/" + encodePathSegment(this.exchange);
6565
}
6666
} else if (this.queue != null) {
67-
return "/q/" + encodePathSegment(this.queue);
67+
return "/queues/" + encodePathSegment(this.queue);
6868
} else {
6969
return null;
7070
}

src/main/java/com/rabbitmq/client/amqp/observation/micrometer/Utils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ abstract class Utils {
2525

2626
private Utils() {}
2727

28-
private static final String EXCHANGE_DELIMITER = "/e/";
28+
private static final String EXCHANGE_DELIMITER = "/exchanges/";
2929
private static final String KEY_DELIMITER = "/";
30-
private static final String QUEUE_DELIMITER = "/q/";
30+
private static final String QUEUE_DELIMITER = "/queues/";
3131
private static final int EXCHANGE_DELIMITER_LENGTH = EXCHANGE_DELIMITER.length();
3232
private static final int KEY_DELIMITER_LENGTH = KEY_DELIMITER.length();
3333
private static final int QUEUE_DELIMITER_LENGTH = QUEUE_DELIMITER.length();

src/test/java/com/rabbitmq/client/amqp/impl/AmqpMessageTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ public class AmqpMessageTest {
2626
@Test
2727
void toShouldBePathEncoded() {
2828
assertThat(new AmqpMessage().toAddress().exchange("foo bar").message().to())
29-
.isEqualTo("/e/foo%20bar");
29+
.isEqualTo("/exchanges/foo%20bar");
3030
}
3131

3232
@Test
3333
void replyToShouldBePathEncoded() {
3434
assertThat(new AmqpMessage().replyToAddress().exchange("foo bar").message().replyTo())
35-
.isEqualTo("/e/foo%20bar");
35+
.isEqualTo("/exchanges/foo%20bar");
3636
}
3737
}

src/test/java/com/rabbitmq/client/amqp/impl/ClientTest.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ void deliveryCount() throws Exception {
9191
publisher.message("".getBytes(UTF_8)), context -> publishLatch.countDown()));
9292

9393
org.apache.qpid.protonj2.client.Connection protonConnection = connection(client);
94-
Receiver receiver = protonConnection.openReceiver("/q/" + q, new ReceiverOptions());
94+
Receiver receiver = protonConnection.openReceiver("/queues/" + q, new ReceiverOptions());
9595
int receivedMessages = 0;
9696
while (receiver.receive(100, TimeUnit.MILLISECONDS) != null) {
9797
receivedMessages++;
@@ -108,15 +108,15 @@ void largeMessage() throws Exception {
108108
connection(client, o -> o.traceFrames(false).maxFrameSize(maxFrameSize));
109109

110110
Sender sender =
111-
connection.openSender("/q/" + q, new SenderOptions().deliveryMode(AT_LEAST_ONCE));
111+
connection.openSender("/queues/" + q, new SenderOptions().deliveryMode(AT_LEAST_ONCE));
112112
byte[] body = new byte[maxFrameSize * 4];
113113
Arrays.fill(body, (byte) 'A');
114114
Tracker tracker = sender.send(Message.create(body));
115115
tracker.awaitSettlement();
116116

117117
Receiver receiver =
118118
connection.openReceiver(
119-
"/q/" + q,
119+
"/queues/" + q,
120120
new ReceiverOptions()
121121
.deliveryMode(AT_LEAST_ONCE)
122122
.autoSettle(false)
@@ -138,7 +138,7 @@ void largeMessageStreamSupport() throws Exception {
138138

139139
StreamSender sender =
140140
connection.openStreamSender(
141-
"/q/" + q, new StreamSenderOptions().deliveryMode(AT_LEAST_ONCE));
141+
"/queues/" + q, new StreamSenderOptions().deliveryMode(AT_LEAST_ONCE));
142142
StreamSenderMessage message = sender.beginMessage();
143143
byte[] body = new byte[maxFrameSize * 4];
144144
Arrays.fill(body, (byte) 'A');
@@ -155,7 +155,7 @@ void largeMessageStreamSupport() throws Exception {
155155

156156
StreamReceiver receiver =
157157
connection.openStreamReceiver(
158-
"/q/" + q,
158+
"/queues/" + q,
159159
new StreamReceiverOptions()
160160
.deliveryMode(AT_LEAST_ONCE)
161161
.autoAccept(false)
@@ -269,7 +269,7 @@ void queueDeletionImpactOnReceiver(TestInfo info) throws Exception {
269269

270270
org.apache.qpid.protonj2.client.Connection protonConnection = connection(client);
271271
Session session = protonConnection.openSession();
272-
Receiver receiver = session.openReceiver("/q/" + queue);
272+
Receiver receiver = session.openReceiver("/queues/" + queue);
273273
receiver.openFuture().get();
274274
Delivery delivery = receiver.tryReceive();
275275
assertThat(delivery).isNull();
@@ -295,7 +295,8 @@ void exchangeDeletionImpactOnSender(TestInfo info) throws Exception {
295295
org.apache.qpid.protonj2.client.Connection protonConnection = connection(client);
296296
Session session = protonConnection.openSession();
297297
Sender sender =
298-
session.openSender("/e/" + exchange, new SenderOptions().deliveryMode(AT_LEAST_ONCE));
298+
session.openSender(
299+
"/exchanges/" + exchange, new SenderOptions().deliveryMode(AT_LEAST_ONCE));
299300
Tracker tracker = sender.send(Message.create(body));
300301
tracker.awaitSettlement(10, SECONDS);
301302
assertThat(tracker.remoteState()).isEqualTo(released());

src/test/java/com/rabbitmq/client/amqp/impl/DefaultAddressBuilderTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ public class DefaultAddressBuilderTest {
2525

2626
@Test
2727
void pathSegmentsShouldBePercentEncoded() {
28-
assertThat(b().exchange("foo").address()).isEqualTo("/e/foo");
29-
assertThat(b().exchange("foo").key("bar").address()).isEqualTo("/e/foo/bar");
30-
assertThat(b().exchange("foo bar").address()).isEqualTo("/e/foo%20bar");
31-
assertThat(b().exchange("foo").key("b ar").address()).isEqualTo("/e/foo/b%20ar");
32-
assertThat(b().queue("foo").address()).isEqualTo("/q/foo");
33-
assertThat(b().queue("foo bar").address()).isEqualTo("/q/foo%20bar");
28+
assertThat(b().exchange("foo").address()).isEqualTo("/exchanges/foo");
29+
assertThat(b().exchange("foo").key("bar").address()).isEqualTo("/exchanges/foo/bar");
30+
assertThat(b().exchange("foo bar").address()).isEqualTo("/exchanges/foo%20bar");
31+
assertThat(b().exchange("foo").key("b ar").address()).isEqualTo("/exchanges/foo/b%20ar");
32+
assertThat(b().queue("foo").address()).isEqualTo("/queues/foo");
33+
assertThat(b().queue("foo bar").address()).isEqualTo("/queues/foo%20bar");
3434
}
3535

3636
TestAddressBuilder b() {

src/test/java/com/rabbitmq/client/amqp/observation/micrometer/UtilsTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ public class UtilsTest {
2828
@ParameterizedTest
2929
@CsvSource(
3030
value = {
31-
"/e/foo/bar,foo,bar",
32-
"/e/foo,foo,NULL",
33-
"/e/foo%20bar,foo bar,NULL",
34-
"/e/foo%20bar/bar%25foo,foo bar,bar%foo",
35-
"/q/bar,'',bar",
36-
"/q/foo%20bar,'',foo bar",
31+
"/exchanges/foo/bar,foo,bar",
32+
"/exchanges/foo,foo,NULL",
33+
"/exchanges/foo%20bar,foo bar,NULL",
34+
"/exchanges/foo%20bar/bar%25foo,foo bar,bar%foo",
35+
"/queues/bar,'',bar",
36+
"/queues/foo%20bar,'',foo bar",
3737
"not a address,NULL,NULL"
3838
},
3939
nullValues = "NULL")

0 commit comments

Comments
 (0)