Set up Spotbugs, squash warnings

Author: acogoluegnes

pom.xml

@@ -59,6 +59,8 @@
         <maven-clean-plugin.version>3.3.2</maven-clean-plugin.version>
         <spotless.version>2.43.0</spotless.version>
         <google-java-format.version>1.22.0</google-java-format.version>
+        <spotbugs-maven-plugin.version>4.8.5.0</spotbugs-maven-plugin.version>
+        <spotbugs.version>4.8.5</spotbugs.version>
         <buildnumber.plugin.version>3.2.0</buildnumber.plugin.version>
         <asciidoctor.maven.plugin.version>3.0.0</asciidoctor.maven.plugin.version>
         <asciidoctorj.version>2.5.13</asciidoctorj.version>
@@ -164,6 +166,12 @@
             <scope>test</scope>
         </dependency>
 
+        <dependency>
+            <groupId>com.github.spotbugs</groupId>
+            <artifactId>spotbugs-annotations</artifactId>
+            <version>${spotbugs.version}</version>
+            <scope>provided</scope>
+        </dependency>
 
     </dependencies>
 
@@ -391,6 +399,26 @@
                 </configuration>
             </plugin>
 
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <version>${spotbugs-maven-plugin.version}</version>
+                <dependencies>
+                    <dependency>
+                        <groupId>com.github.spotbugs</groupId>
+                        <artifactId>spotbugs</artifactId>
+                        <version>${spotbugs.version}</version>
+                    </dependency>
+                </dependencies>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+
         </plugins>
 
     </build>
@@ -407,7 +435,6 @@
             </properties>
         </profile>
 
-
         <profile>
             <id>jvm-test-arguments-java-21-and-more</id>
             <activation>

src/main/java/com/rabbitmq/model/ByteCapacity.java

@@ -108,7 +108,7 @@ public long toBytes() {
   public static ByteCapacity from(String value) {
     Matcher matcher = PATTERN.matcher(value);
     if (matcher.matches()) {
-      long size = Long.valueOf(matcher.group(GROUP_SIZE));
+      long size = Long.parseLong(matcher.group(GROUP_SIZE));
       String unit = matcher.group(GROUP_UNIT);
       ByteCapacity result;
       if (unit == null) {

src/main/java/com/rabbitmq/model/amqp/AmqpConnection.java

@@ -44,7 +44,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-class AmqpConnection extends ResourceBase implements Connection {
+final class AmqpConnection extends ResourceBase implements Connection {
 
   private static final Predicate<Throwable> RECOVERY_PREDICATE =
       t -> {

src/main/java/com/rabbitmq/model/amqp/AmqpConsumer.java

@@ -44,7 +44,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-class AmqpConsumer extends ResourceBase implements Consumer {
+final class AmqpConsumer extends ResourceBase implements Consumer {
 
   private static final AtomicLong ID_SEQUENCE = new AtomicLong(0);
 

src/main/java/com/rabbitmq/model/amqp/AmqpEnvironmentBuilder.java

@@ -22,6 +22,7 @@
 import com.rabbitmq.model.EnvironmentBuilder;
 import com.rabbitmq.model.metrics.MetricsCollector;
 import com.rabbitmq.model.metrics.NoOpMetricsCollector;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.concurrent.ExecutorService;
 
 public class AmqpEnvironmentBuilder implements EnvironmentBuilder {
@@ -43,6 +44,7 @@ public AmqpEnvironmentBuilder metricsCollector(MetricsCollector metricsCollector
     return this;
   }
 
+  @SuppressFBWarnings("EI_EXPOSE_REP")
   public EnvironmentConnectionSettings connectionSettings() {
     return this.connectionSettings;
   }

src/main/java/com/rabbitmq/model/amqp/AmqpExchangeSpecification.java

@@ -25,12 +25,13 @@
 
 class AmqpExchangeSpecification implements Management.ExchangeSpecification {
 
+  private static final boolean DURABLE = true;
+  private static final boolean INTERNAL = false;
+
   private final AmqpManagement management;
 
   private String name;
   private String type = Management.ExchangeType.DIRECT.name().toLowerCase(Locale.ENGLISH);
-  private final boolean durable = true;
-  private final boolean internal = false;
   private boolean autoDelete = false;
   private final Map<String, Object> arguments = new LinkedHashMap<>();
 
@@ -77,9 +78,9 @@ public void declare() {
     // TODO check name is specified (server-named entities not allowed)
     Map<String, Object> body = new LinkedHashMap<>();
     body.put("type", this.type);
-    body.put("durable", this.durable);
+    body.put("durable", DURABLE);
     body.put("auto_delete", this.autoDelete);
-    body.put("internal", this.internal);
+    body.put("internal", INTERNAL);
     body.put("arguments", this.arguments);
     this.management.declareExchange(this.name, body);
     this.management.recovery().exchangeDeclared(this);

src/main/java/com/rabbitmq/model/amqp/AmqpPublisher.java

@@ -31,7 +31,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-class AmqpPublisher extends ResourceBase implements Publisher {
+final class AmqpPublisher extends ResourceBase implements Publisher {
 
   private static final AtomicLong ID_SEQUENCE = new AtomicLong(0);
 

src/main/java/com/rabbitmq/model/amqp/AmqpQueueSpecification.java

@@ -32,8 +32,8 @@
 class AmqpQueueSpecification implements Management.QueueSpecification {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(AmqpQueueSpecification.class);
-
   private static final Duration TEN_YEARS = Duration.ofDays(365 * 10);
+  private static final boolean DURABLE = true;
 
   private final AmqpManagement management;
 
@@ -44,7 +44,6 @@ class AmqpQueueSpecification implements Management.QueueSpecification {
   // the user until the fix arrives)
   private boolean shortcutArguments = false;
   private String name;
-  private final boolean durable = true;
   private boolean exclusive = false;
   private boolean autoDelete = false;
   private final Map<String, Object> arguments = new LinkedHashMap<>();
@@ -189,7 +188,7 @@ public Management.QueueInfo declare() {
     // TODO check name is specified (server-named entities not allowed)
     // generate a random name if name not specified
     Map<String, Object> body = new LinkedHashMap<>();
-    body.put("durable", this.durable);
+    body.put("durable", DURABLE);
     body.put("exclusive", this.exclusive);
     body.put("auto_delete", this.autoDelete);
     body.put("arguments", this.arguments);

src/main/java/com/rabbitmq/model/amqp/RecordingTopologyListener.java

@@ -28,7 +28,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-class RecordingTopologyListener implements TopologyListener, AutoCloseable {
+final class RecordingTopologyListener implements TopologyListener, AutoCloseable {
 
   private static final Duration TIMEOUT = Duration.ofSeconds(60);