Skip to content

Commit 413068a

Browse files
committed
Only add x-dotnet-pub-seq-no when tracking enabled
If a user only enables publisher confirms for a channel, but _NOT_ automatic tracking, it will be up to them to correlate a `basic.return` with a sequence number.
1 parent af007e1 commit 413068a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

projects/RabbitMQ.Client/Impl/Channel.BasicPublish.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ void MaybeAddActivityToHeaders(IDictionary<string, object?> headers,
215215

216216
void MaybeAddPublishSequenceNumberToHeaders(IDictionary<string, object?> headers)
217217
{
218-
if (_publisherConfirmationsEnabled)
218+
if (_publisherConfirmationsEnabled && _publisherConfirmationTrackingEnabled)
219219
{
220220
byte[] publishSequenceNumberBytes = new byte[8];
221221
NetworkOrderSerializer.WriteUInt64(ref publishSequenceNumberBytes.GetStart(), publishSequenceNumber);

projects/RabbitMQ.Client/Impl/Channel.PublisherConfirms.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ private void HandleNack(ulong deliveryTag, bool multiple, bool isReturn)
228228
[MethodImpl(MethodImplOptions.AggressiveInlining)]
229229
private void HandleReturn(BasicReturnEventArgs basicReturnEvent)
230230
{
231-
if (_publisherConfirmationsEnabled)
231+
if (_publisherConfirmationsEnabled && _publisherConfirmationTrackingEnabled)
232232
{
233233
ulong publishSequenceNumber = 0;
234234
IReadOnlyBasicProperties props = basicReturnEvent.BasicProperties;

0 commit comments

Comments
 (0)