Skip to content

Commit 4506a70

Browse files
committed
do not pass the model in Work.Execute
1 parent f1af6ac commit 4506a70

File tree

8 files changed

+15
-13
lines changed

8 files changed

+15
-13
lines changed

projects/RabbitMQ.Client/client/impl/AsyncConsumerDispatcher.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public void HandleBasicCancel(IBasicConsumer consumer, string consumerTag)
6666
public void HandleModelShutdown(IBasicConsumer consumer, ShutdownEventArgs reason)
6767
{
6868
// the only case where we ignore the shutdown flag.
69-
Schedule(new ModelShutdown(consumer, reason));
69+
Schedule(new ModelShutdown(consumer, reason, _model));
7070
}
7171

7272
private void ScheduleUnlessShuttingDown<TWork>(TWork work)

projects/RabbitMQ.Client/client/impl/AsyncConsumerWorkService.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ private async Task Loop()
8989
{
9090
try
9191
{
92-
Task task = work.Execute(_model);
92+
Task task = work.Execute();
9393
if (!task.IsCompleted)
9494
{
9595
await task.ConfigureAwait(false);
@@ -145,7 +145,7 @@ private static async Task HandleConcurrent(Work work, IModel model, SemaphoreSli
145145
{
146146
try
147147
{
148-
Task task = work.Execute(model);
148+
Task task = work.Execute();
149149
if (!task.IsCompleted)
150150
{
151151
await task.ConfigureAwait(false);

projects/RabbitMQ.Client/client/impl/BasicCancel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public BasicCancel(IBasicConsumer consumer, string consumerTag) : base(consumer)
1313
_consumerTag = consumerTag;
1414
}
1515

16-
protected override Task Execute(IModel model, IAsyncBasicConsumer consumer)
16+
protected override Task Execute(IAsyncBasicConsumer consumer)
1717
{
1818
return consumer.HandleBasicCancel(_consumerTag);
1919
}

projects/RabbitMQ.Client/client/impl/BasicCancelOk.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public BasicCancelOk(IBasicConsumer consumer, string consumerTag) : base(consume
1313
_consumerTag = consumerTag;
1414
}
1515

16-
protected override Task Execute(IModel model, IAsyncBasicConsumer consumer)
16+
protected override Task Execute(IAsyncBasicConsumer consumer)
1717
{
1818
return consumer.HandleBasicCancelOk(_consumerTag);
1919
}

projects/RabbitMQ.Client/client/impl/BasicConsumeOk.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public BasicConsumeOk(IBasicConsumer consumer, string consumerTag) : base(consum
1313
_consumerTag = consumerTag;
1414
}
1515

16-
protected override Task Execute(IModel model, IAsyncBasicConsumer consumer)
16+
protected override Task Execute(IAsyncBasicConsumer consumer)
1717
{
1818
return consumer.HandleBasicConsumeOk(_consumerTag);
1919
}

projects/RabbitMQ.Client/client/impl/BasicDeliver.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public BasicDeliver(IBasicConsumer consumer,
3535
_body = body;
3636
}
3737

38-
protected override Task Execute(IModel model, IAsyncBasicConsumer consumer)
38+
protected override Task Execute(IAsyncBasicConsumer consumer)
3939
{
4040
return consumer.HandleBasicDeliver(_consumerTag,
4141
_deliveryTag,

projects/RabbitMQ.Client/client/impl/ModelShutdown.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,19 @@ namespace RabbitMQ.Client.Impl
55
internal sealed class ModelShutdown : Work
66
{
77
private readonly ShutdownEventArgs _reason;
8+
private readonly IModel _model;
89

910
public override string Context => "HandleModelShutdown";
1011

11-
public ModelShutdown(IBasicConsumer consumer, ShutdownEventArgs reason) : base(consumer)
12+
public ModelShutdown(IBasicConsumer consumer, ShutdownEventArgs reason, IModel model) : base(consumer)
1213
{
1314
_reason = reason;
15+
_model = model;
1416
}
1517

16-
protected override Task Execute(IModel model, IAsyncBasicConsumer consumer)
18+
protected override Task Execute(IAsyncBasicConsumer consumer)
1719
{
18-
return consumer.HandleModelShutdown(model, _reason);
20+
return consumer.HandleModelShutdown(_model, _reason);
1921
}
2022
}
2123
}

projects/RabbitMQ.Client/client/impl/Work.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ protected Work(IBasicConsumer consumer)
1313
Consumer = (IAsyncBasicConsumer)consumer;
1414
}
1515

16-
public Task Execute(IModel model)
16+
public Task Execute()
1717
{
18-
return Execute(model, Consumer);
18+
return Execute(Consumer);
1919
}
2020

21-
protected abstract Task Execute(IModel model, IAsyncBasicConsumer consumer);
21+
protected abstract Task Execute(IAsyncBasicConsumer consumer);
2222

2323
public virtual void PostExecute()
2424
{

0 commit comments

Comments
 (0)