Skip to content

Commit 4f1cceb

Browse files
author
Alexandru Scvortov
committed
remove confirm.select{multiple} from .NET API
1 parent 26cbe77 commit 4f1cceb

File tree

4 files changed

+14
-21
lines changed

4 files changed

+14
-21
lines changed

docs/specs/amqp0-9-1.stripped.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,8 +488,6 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
488488
<method name="select" synchronous="1" index="10">
489489
<chassis name="server" implement="MUST"/>
490490
<response name="select-ok"/>
491-
<field name = "multiple" type = "bit">
492-
</field>
493491
<field name = "nowait" type = "bit">
494492
</field>
495493
</method>

docs/specs/amqp0-9-1.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2859,15 +2859,6 @@
28592859
</doc>
28602860
<chassis name="server" implement="MUST"/>
28612861
<response name="select-ok"/>
2862-
<field name = "multiple" type = "bit">
2863-
acknowledge multiple messages
2864-
<doc>
2865-
If set to 1, the delivery tag in the returned acks is
2866-
treated as "up to and including", so that the server can
2867-
acknowledge multiple messages with a single method. If set
2868-
to zero, the delivery tag refers to a single message.
2869-
</doc>
2870-
</field>
28712862
<field name = "nowait" type = "bit">
28722863
do not send a reply method
28732864
<doc>

projects/client/RabbitMQ.Client/src/client/api/IModel.cs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -317,12 +317,16 @@ uint QueueDelete(string queue,
317317
///<summary>Enable publisher acknowledgements.</summary>
318318
[AmqpMethodDoNotImplement(null)]
319319
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_8qpid")]
320-
void ConfirmSelect(bool multiple);
320+
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_8")]
321+
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_9")]
322+
void ConfirmSelect();
321323

322324
///<summary>Enable publisher acknowledgements.</summary>
323325
[AmqpMethodDoNotImplement(null)]
324326
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_8qpid")]
325-
void ConfirmSelect(bool multiple, bool nowait);
327+
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_8")]
328+
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_9")]
329+
void ConfirmSelect(bool nowait);
326330

327331

328332
///<summary>Start a Basic content-class consumer.</summary>
@@ -615,9 +619,10 @@ void _Private_BasicConsume(string queue,
615619
///confirm API calls this while also managing internal
616620
///datastructures.</summary>
617621
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_8qpid")]
622+
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_8")]
623+
[AmqpUnsupported("RabbitMQ.Client.Framing.v0_9")]
618624
[AmqpMethodMapping(null, "confirm", "select")]
619-
void _Private_ConfirmSelect(bool multiple,
620-
[AmqpNowaitArgument(null)]
625+
void _Private_ConfirmSelect([AmqpNowaitArgument(null)]
621626
bool nowait);
622627

623628

projects/client/RabbitMQ.Client/src/client/impl/ModelBase.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -748,18 +748,17 @@ public abstract uint QueueDelete(string queue,
748748
bool ifEmpty,
749749
bool nowait);
750750

751-
public void ConfirmSelect(bool multiple) {
752-
ConfirmSelect(multiple, false);
751+
public void ConfirmSelect() {
752+
ConfirmSelect(false);
753753
}
754754

755-
public void ConfirmSelect(bool multiple, bool nowait) {
755+
public void ConfirmSelect(bool nowait) {
756756
m_pubMsgCount = 0;
757-
_Private_ConfirmSelect(multiple, nowait);
757+
_Private_ConfirmSelect(nowait);
758758
}
759759

760760

761-
public abstract void _Private_ConfirmSelect(bool multiple,
762-
bool nowait);
761+
public abstract void _Private_ConfirmSelect(bool nowait);
763762

764763
public string BasicConsume(string queue,
765764
IDictionary arguments,

0 commit comments

Comments
 (0)