* Remove TxSelect, TxCommit and TxRollback

Author: lukebakken

projects/RabbitMQ.Client/PublicAPI.Unshipped.txt

@@ -498,9 +498,6 @@ RabbitMQ.Client.IChannel.FlowControl -> System.EventHandler<RabbitMQ.Client.Even
 RabbitMQ.Client.IChannel.IsClosed.get -> bool
 RabbitMQ.Client.IChannel.IsOpen.get -> bool
 RabbitMQ.Client.IChannel.NextPublishSeqNo.get -> ulong
-RabbitMQ.Client.IChannel.TxCommit() -> void
-RabbitMQ.Client.IChannel.TxRollback() -> void
-RabbitMQ.Client.IChannel.TxSelect() -> void
 RabbitMQ.Client.IChannel.WaitForConfirms() -> bool
 RabbitMQ.Client.IChannel.WaitForConfirmsAsync(System.Threading.CancellationToken token = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<bool>
 RabbitMQ.Client.IChannel.WaitForConfirmsOrDie() -> void

projects/RabbitMQ.Client/client/api/IChannel.cs

@@ -650,24 +650,24 @@ Task<QueueDeclareOk> QueueDeclareAsync(string queue, bool durable, bool exclusiv
         /// </remarks>
         Task QueueUnbindAsync(string queue, string exchange, string routingKey, IDictionary<string, object> arguments);
 
-        /// <summary>Commit this session's active TX transaction.</summary>
-        void TxCommit();
-
         /// <summary>Asynchronously commit this session's active TX transaction.</summary>
         Task TxCommitAsync();
 
-        /// <summary>Roll back this session's active TX transaction.</summary>
-        void TxRollback();
-
         /// <summary>Asynchronously roll back this session's active TX transaction.</summary>
         Task TxRollbackAsync();
 
-        /// <summary>Enable TX mode for this session.</summary>
-        void TxSelect();
-
         /// <summary>Asynchronously enable TX mode for this session.</summary>
         Task TxSelectAsync();
 
+#if SYNC_API
+        /// <summary>Commit this session's active TX transaction.</summary>
+        void TxCommit();
+        /// <summary>Roll back this session's active TX transaction.</summary>
+        void TxRollback();
+        /// <summary>Enable TX mode for this session.</summary>
+        void TxSelect();
+#endif
+
         /// <summary>
         /// Wait until all published messages on this channel have been confirmed.
         /// </summary>

projects/RabbitMQ.Client/client/framing/Channel.cs

@@ -256,7 +256,6 @@ public override void QueueUnbind(string queue, string exchange, string routingKe
         {
             ChannelRpc(new QueueUnbind(queue, exchange, routingKey, arguments), ProtocolCommandId.QueueUnbindOk);
         }
-#endif
 
         public override void TxCommit()
         {
@@ -272,6 +271,7 @@ public override void TxSelect()
         {
             ChannelRpc(new TxSelect(), ProtocolCommandId.TxSelectOk);
         }
+#endif
 
         protected override bool DispatchAsynchronous(in IncomingCommand cmd)
         {

projects/RabbitMQ.Client/client/impl/AutorecoveringChannel.cs

@@ -646,29 +646,30 @@ await _connection.DeleteAutoDeleteExchangeAsync(exchange, recordedEntitiesSemaph
                 .ConfigureAwait(false);
         }
 
-        public void TxCommit()
-            => InnerChannel.TxCommit();
-
         public Task TxCommitAsync()
             => InnerChannel.TxCommitAsync();
 
-        public void TxRollback()
-            => InnerChannel.TxRollback();
 
         public Task TxRollbackAsync()
             => InnerChannel.TxRollbackAsync();
 
-        public void TxSelect()
+        public Task TxSelectAsync()
         {
-            InnerChannel.TxSelect();
             _usesTransactions = true;
+            return InnerChannel.TxSelectAsync();
         }
 
-        public Task TxSelectAsync()
+#if SYNC_API
+        public void TxCommit()
+            => InnerChannel.TxCommit();
+        public void TxRollback()
+            => InnerChannel.TxRollback();
+        public void TxSelect()
         {
+            InnerChannel.TxSelect();
             _usesTransactions = true;
-            return InnerChannel.TxSelectAsync();
         }
+#endif
 
         public bool WaitForConfirms()
             => InnerChannel.WaitForConfirms();

projects/RabbitMQ.Client/client/impl/ChannelBase.cs

@@ -1914,7 +1914,9 @@ await ModelSendAsync(method)
             }
         }
 
+#if SYNC_API
         public abstract void TxCommit();
+#endif
 
         public async Task TxCommitAsync()
         {
@@ -1939,7 +1941,9 @@ await ModelSendAsync(method)
             }
         }
 
+#if SYNC_API
         public abstract void TxRollback();
+#endif
 
         public async Task TxRollbackAsync()
         {
@@ -1964,7 +1968,9 @@ await ModelSendAsync(method)
             }
         }
 
+#if SYNC_API
         public abstract void TxSelect();
+#endif
 
         public async Task TxSelectAsync()
         {