Add Note

lukebakken · lukebakken · commit 857cbde27ea1 · 2024-10-03T10:06:25.000-07:00
diff --git a/projects/RabbitMQ.Client/Impl/ChannelBase.cs b/projects/RabbitMQ.Client/Impl/ChannelBase.cs
@@ -1841,6 +1841,11 @@ await _confirmSemaphore.WaitAsync(cancellationToken)
                         }
                         else
                         {
+                            /*
+                             * Note:
+                             * In the case of `basic.return`, the TCS will have been handled and removed by HandleBasicReturn()
+                             * RabbitMQ still sends `basic.ack`, so the TCS will not be in the dict, hence, TryGetValue here
+                             */
                             if (_confirmsTaskCompletionSources.TryGetValue(deliveryTag, out TaskCompletionSource<bool>? tcs))
                             {
                                 tcs.SetResult(isAck);

Original file line number	Diff line number	Diff line change
`@@ -1841,6 +1841,11 @@ await _confirmSemaphore.WaitAsync(cancellationToken)`
`1841`	`1841`	`}`
`1842`	`1842`	`else`
`1843`	`1843`	`{`
	`1844`	`+ /*`
	`1845`	`+ * Note:`
	`1846`	+ * In the case of `basic.return`, the TCS will have been handled and removed by HandleBasicReturn()
	`1847`	+ * RabbitMQ still sends `basic.ack`, so the TCS will not be in the dict, hence, TryGetValue here
	`1848`	`+ */`
`1844`	`1849`	`if (_confirmsTaskCompletionSources.TryGetValue(deliveryTag, out TaskCompletionSource<bool>? tcs))`
`1845`	`1850`	`{`
`1846`	`1851`	`tcs.SetResult(isAck);`