Fix RabbitMQ version parsing

lukebakken · lukebakken · commit 8d90a3594cc1 · 2020-06-10T10:43:55.000-07:00
Turns out that Version.TryParse does not handle semver, and the following version will not be parsed: 3.8.5-alpha.8 This change removes all characters following the dash and the dash itself. https://ci.rabbitmq.com/teams/main/pipelines/dotnet/jobs/test/builds/343
diff --git a/projects/Unit/TestUpdateSecret.cs b/projects/Unit/TestUpdateSecret.cs
@@ -69,6 +69,13 @@ private bool RabbitMQ380OrHigher()
             if (properties.TryGetValue("version", out object versionVal))
             {
                 string versionStr = Encoding.UTF8.GetString((byte[])versionVal);
+
+                int dashIdx = versionStr.IndexOf('-');
+                if (dashIdx > 0)
+                {
+                    versionStr = versionStr.Remove(dashIdx);
+                }
+
                 if (Version.TryParse(versionStr, out Version version))
                 {
                     return version >= new Version(3, 8);

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,13 @@ private bool RabbitMQ380OrHigher()`
`69`	`69`	`if (properties.TryGetValue("version", out object versionVal))`
`70`	`70`	`{`
`71`	`71`	`string versionStr = Encoding.UTF8.GetString((byte[])versionVal);`
	`72`	`+`
	`73`	`+ int dashIdx = versionStr.IndexOf('-');`
	`74`	`+ if (dashIdx > 0)`
	`75`	`+ {`
	`76`	`+ versionStr = versionStr.Remove(dashIdx);`
	`77`	`+ }`
	`78`	`+`
`72`	`79`	`if (Version.TryParse(versionStr, out Version version))`
`73`	`80`	`{`
`74`	`81`	`return version >= new Version(3, 8);`