remove enumerator allocation on IList<T> / use List type instead of interface

Author: bollhals

projects/RabbitMQ.Client/client/api/ConnectionFactory.cs

@@ -334,14 +334,16 @@ public Uri Uri
         public IAuthMechanismFactory AuthMechanismFactory(IList<string> mechanismNames)
         {
             // Our list is in order of preference, the server one is not.
-            foreach (IAuthMechanismFactory factory in AuthMechanisms)
+            for (int index = 0; index < AuthMechanisms.Count; index++)
             {
+                IAuthMechanismFactory factory = AuthMechanisms[index];
                 string factoryName = factory.Name;
                 if (mechanismNames.Any<string>(x => string.Equals(x, factoryName, StringComparison.OrdinalIgnoreCase)))
                 {
                     return factory;
                 }
             }
+
             return null;
         }
 

projects/RabbitMQ.Client/client/impl/Command.cs

@@ -138,8 +138,9 @@ internal static List<OutboundFrame> CalculateFrames(int channelNumber, Connectio
         {
             var frames = new List<OutboundFrame>();
 
-            foreach (Command cmd in commands)
+            for (int index = 0; index < commands.Count; index++)
             {
+                Command cmd = commands[index];
                 frames.Add(new MethodOutboundFrame(channelNumber, cmd.Method));
                 if (cmd.Method.HasContent)
                 {

projects/RabbitMQ.Client/client/impl/Connection.cs

@@ -730,10 +730,9 @@ public void PrettyPrintShutdownReport()
             {
                 Console.Error.WriteLine(
 "Log of errors while closing connection {0}:", this);
-                foreach (ShutdownReportEntry entry in ShutdownReport)
+                for (int index = 0; index < ShutdownReport.Count; index++)
                 {
-                    Console.Error.WriteLine(
-entry.ToString());
+                    Console.Error.WriteLine(ShutdownReport[index].ToString());
                 }
             }
         }

projects/RabbitMQ.Client/client/impl/WireFormatting.cs

@@ -95,8 +95,8 @@ public static void DecimalToAmqp(decimal value, out byte scale, out int mantissa
 
         public static IList ReadArray(ReadOnlyMemory<byte> memory, out int bytesRead)
         {
-            IList array = new List<object>();
-            long arrayLength = NetworkOrderDeserializer.ReadUInt32(memory);
+            uint arrayLength = NetworkOrderDeserializer.ReadUInt32(memory);
+            List<object> array = new List<object>((int)arrayLength);
             bytesRead = 4;
             while (bytesRead - 4 < arrayLength)
             {
@@ -247,9 +247,9 @@ public static int WriteArray(Memory<byte> memory, IList val)
             else
             {
                 int bytesWritten = 0;
-                foreach (object entry in val)
+                for (int index = 0; index < val.Count; index++)
                 {
-                    bytesWritten += WriteFieldValue(memory.Slice(4 + bytesWritten), entry); ;
+                    bytesWritten += WriteFieldValue(memory.Slice(4 + bytesWritten), val[index]);
                 }
 
                 NetworkOrderSerializer.WriteUInt32(memory, (uint)bytesWritten);
@@ -265,9 +265,9 @@ public static int GetArrayByteCount(IList val)
                 return byteCount;
             }
 
-            foreach (object entry in val)
+            for (int index = 0; index < val.Count; index++)
             {
-                byteCount += GetFieldValueByteCount(entry);
+                byteCount += GetFieldValueByteCount(val[index]);
             }
 
             return byteCount;