Cosmetic fixes, remove commented out code

Author: lukebakken

projects/client/RabbitMQ.Client/src/client/impl/AutorecoveringConnection.cs

@@ -962,7 +962,7 @@ private enum RecoveryConnectionState
         private RecoveryConnectionState _recoveryLoopState = RecoveryConnectionState.Connected;
 
         private readonly ConcurrentQueue<RecoveryCommand> _recoveryLoopCommandQueue = new ConcurrentQueue<RecoveryCommand>();
-        readonly SemaphoreSlim _semaphore = new SemaphoreSlim(0);
+        private readonly SemaphoreSlim _semaphore = new SemaphoreSlim(0);
         private readonly CancellationTokenSource _recoveryCancellationToken = new CancellationTokenSource();
         private readonly TaskCompletionSource<int> _recoveryLoopComplete = new TaskCompletionSource<int>();
 

projects/client/RabbitMQ.Client/src/client/impl/ModelBase.cs

@@ -180,8 +180,6 @@ public bool IsOpen
             get { return CloseReason == null; }
         }
 
-
-
         public ulong NextPublishSeqNo { get => _nextPublishSeqNo; }
 
         public ISession Session { get; private set; }

projects/client/RabbitMQ.Client/src/client/impl/SocketFrameHandler.cs

@@ -253,36 +253,6 @@ public void WriteFrameSet(IList<OutboundFrame> frames)
             {
                 _writer.Flush();
             }
-            /*
-            int bufferSize = 0;
-            for (int i = 0; i < frames.Count; i++)
-            {
-                bufferSize += frames[i].GetMinimumBufferSize();
-            }
-
-            using (IMemoryOwner<byte> memory = MemoryPool<byte>.Shared.Rent(bufferSize))
-            {
-                int frameBytes = 0;
-                Memory<byte> slice = memory.Memory.Slice(0, bufferSize);
-                for (int i = 0; i < frames.Count; i++)
-                {
-                    OutboundFrame frame = frames[i];
-                    int frameLength = frame.GetMinimumBufferSize();
-                    Memory<byte> frameSlice = slice.Slice(frameBytes, frameLength);
-                    frame.WriteTo(frameSlice);
-                    frameBytes += frame.ByteCount;
-                }
-
-                _socket.Client.Poll(_writeableStateTimeoutMicroSeconds, SelectMode.SelectWrite);
-                if (MemoryMarshal.TryGetArray(slice.Slice(0, frameBytes), out ArraySegment<byte> segment))
-                {
-                    Write(segment);
-                    return;
-                }
-
-                throw new InvalidOperationException("Unable to get array segment from memory.");
-            }
-            */
         }
 
         private void Write(ArraySegment<byte> bufferSegment, bool flush)

projects/client/Unit/src/unit/WireFormattingFixture.cs

@@ -49,27 +49,6 @@ namespace RabbitMQ.Client.Unit
 {
     class WireFormattingFixture
     {
-        public static NetworkBinaryReader Reader(byte[] content)
-        {
-            return new NetworkBinaryReader(new MemoryStream(content));
-        }
-
-        public static NetworkBinaryWriter Writer()
-        {
-            return new NetworkBinaryWriter(new MemoryStream());
-        }
-
-        public static byte[] Contents(NetworkBinaryWriter w)
-        {
-            return ((MemoryStream)w.BaseStream).ToArray();
-        }
-
-        public void Check(NetworkBinaryWriter w, byte[] expected)
-        {
-            byte[] actual = Contents(w);
-            Check(actual, expected);
-        }
-
         public void Check(byte[] actual, byte[] expected)
         {
             try