Skip to content

Commit ba18eef

Browse files
committed
Trying to stabilize Activity tests
1 parent 79a6e5d commit ba18eef

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

projects/Test/Integration/TestActivitySource.cs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ public async Task TestPublisherAndConsumerActivityTags(bool useRoutingKeyAsOpera
8686
var _activities = new List<Activity>();
8787
using (ActivityListener activityListener = StartActivityListener(_activities))
8888
{
89+
await Task.Delay(500);
8990
string queueName = $"{Guid.NewGuid()}";
9091
QueueDeclareOk q = await _channel.QueueDeclareAsync(queueName);
9192
byte[] sendBody = Encoding.UTF8.GetBytes("hi");
@@ -106,7 +107,7 @@ public async Task TestPublisherAndConsumerActivityTags(bool useRoutingKeyAsOpera
106107
Assert.True(await consumerReceivedTcs.Task);
107108

108109
await _channel.BasicCancelAsync(consumerTag);
109-
110+
await Task.Delay(500);
110111
AssertActivityData(useRoutingKeyAsOperationName, queueName, _activities, true);
111112
}
112113
}
@@ -122,6 +123,8 @@ public async Task TestPublisherAndConsumerActivityTagsAsync(bool useRoutingKeyAs
122123
var activities = new List<Activity>();
123124
using (ActivityListener activityListener = StartActivityListener(activities))
124125
{
126+
await Task.Delay(500);
127+
125128
string queueName = $"{Guid.NewGuid()}";
126129
QueueDeclareOk q = await _channel.QueueDeclareAsync(queueName);
127130
byte[] sendBody = Encoding.UTF8.GetBytes("hi");
@@ -142,7 +145,7 @@ public async Task TestPublisherAndConsumerActivityTagsAsync(bool useRoutingKeyAs
142145
Assert.True(await consumerReceivedTcs.Task);
143146

144147
await _channel.BasicCancelAsync(consumerTag);
145-
148+
await Task.Delay(500);
146149
AssertActivityData(useRoutingKeyAsOperationName, queueName, activities, true);
147150
}
148151
}
@@ -153,11 +156,11 @@ public async Task TestPublisherAndConsumerActivityTagsAsync(bool useRoutingKeyAs
153156
public async Task TestPublisherAndBasicGetActivityTags(bool useRoutingKeyAsOperationName)
154157
{
155158
await _channel.ConfirmSelectAsync();
156-
157159
RabbitMQActivitySource.UseRoutingKeyAsOperationName = useRoutingKeyAsOperationName;
158160
var activities = new List<Activity>();
159161
using (ActivityListener activityListener = StartActivityListener(activities))
160162
{
163+
await Task.Delay(500);
161164
string queue = $"queue-{Guid.NewGuid()}";
162165
const string msg = "for basic.get";
163166

@@ -172,13 +175,13 @@ public async Task TestPublisherAndBasicGetActivityTags(bool useRoutingKeyAsOpera
172175
Assert.Equal(msg, Encoding.UTF8.GetString(res.Body.ToArray()));
173176
ok = await _channel.QueueDeclarePassiveAsync(queue);
174177
Assert.Equal(0u, ok.MessageCount);
178+
await Task.Delay(500);
179+
AssertActivityData(useRoutingKeyAsOperationName, queue, activities, false);
175180
}
176181
finally
177182
{
178183
await _channel.QueueDeleteAsync(queue);
179184
}
180-
181-
AssertActivityData(useRoutingKeyAsOperationName, queue, activities, false);
182185
}
183186
}
184187

@@ -191,7 +194,7 @@ private static ActivityListener StartActivityListener(List<Activity> activities)
191194
ActivitySamplingResult.AllDataAndRecorded;
192195
activityListener.ShouldListenTo =
193196
activitySource => activitySource.Name.StartsWith("RabbitMQ.Client.");
194-
activityListener.ActivityStarted = activity => activities.Add(activity);
197+
activityListener.ActivityStarted = activities.Add;
195198
ActivitySource.AddActivityListener(activityListener);
196199
return activityListener;
197200
}

0 commit comments

Comments
 (0)