Skip to content

Commit c007da0

Browse files
committed
Adding messaging.operation for all operations, not just publish.
1 parent 252a00d commit c007da0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

projects/RabbitMQ.Client/client/impl/RabbitMQActivitySource.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ internal static Activity Send(BasicPublish basicPublish, int bodySize)
3737
{
3838
if (source.HasListeners())
3939
{
40-
Activity activity = StartRabbitMQActivity($"{basicPublish._routingKey} send", ActivityKind.Producer, Activity.Current?.Context ?? default);
40+
Activity activity = StartRabbitMQActivity($"{basicPublish._routingKey} publish", ActivityKind.Producer, Activity.Current?.Context ?? default);
4141
if (activity != null && activity.IsAllDataRequested)
4242
{
4343
PopulateMessagingTags("publish", basicPublish._routingKey, basicPublish._exchange, 0, null, bodySize, activity);
@@ -130,7 +130,7 @@ private static void PopulateMessagingTags(string operation, string routingKey, s
130130
{
131131

132132
activity
133-
.SetTag(MessagingOperation, operation == "publish" ? operation : null)
133+
.SetTag(MessagingOperation, operation)
134134
.SetTag(MessagingDestination, string.IsNullOrEmpty(exchange) ? "amq.default" : exchange)
135135
.SetTag(MessagingDestinationKind, "topic")
136136
.SetTag(MessagingDestinationRoutingKey, routingKey)

projects/Unit/ActivitySource/TestActivitySource.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ void AssertIntTagGreaterThanZero(Activity activity, string name)
8484

8585
var activityArray = activities.ToArray();
8686
Assert.NotEmpty(activityArray);
87-
Activity sendActivity = activityArray.Single(x => x.OperationName == $"{queueName} send");
87+
Activity sendActivity = activityArray.Single(x => x.OperationName == $"{queueName} publish");
8888
Activity receiveActivity = activityArray.Single(x => x.OperationName == $"{queueName} receive");
8989
Activity processActivity = activityArray.Single(x => x.OperationName == $"{queueName} process");
9090
Assert.Equal(ActivityKind.Producer, sendActivity.Kind);

0 commit comments

Comments
 (0)