Merge pull request #189 from rabbitmq/rabbitmq-dotnet-client-187

ensure client provided name is properly assigned

Author: michaelklishin

projects/client/RabbitMQ.Client/src/client/impl/Connection.cs

@@ -115,7 +115,7 @@ public class Connection : IConnection
 
         public Connection(IConnectionFactory factory, bool insist, IFrameHandler frameHandler, string clientProvidedName = null)
         {
-            clientProvidedName = clientProvidedName;
+            this.ClientProvidedName = clientProvidedName;
             KnownHosts = null;
             FrameMax = 0;
             m_factory = factory;

projects/client/Unit/src/unit/TestConnectionFactory.cs

@@ -91,7 +91,30 @@ public void TestCreateConnectionWithClientProvidedNameUsesSpecifiedPort()
             cf.Port = 1234;
             using(var conn = cf.CreateConnection("some_name"));
         }
+
+        [Test]
+        public void TestCreateConnectionWithClientProvidedNameUsesName()
+        {
+            var cf = new ConnectionFactory();
+            cf.AutomaticRecoveryEnabled = false;
+            using(var conn = cf.CreateConnection("some_name"))
+            {
+                Assert.AreEqual("some_name", conn.ClientProvidedName);
+                Assert.AreEqual("some_name", conn.ClientProperties["connection_name"]);
+            }
+        }
 
+        [Test]
+        public void TestCreateConnectionWithClientProvidedNameAndAutorecoveryUsesName()
+        {
+            var cf = new ConnectionFactory();
+            cf.AutomaticRecoveryEnabled = true;
+            using(var conn = cf.CreateConnection("some_name"))
+            {
+                Assert.AreEqual("some_name", conn.ClientProvidedName);
+                Assert.AreEqual("some_name", conn.ClientProperties["connection_name"]);
+            }
+        }
         [Test]
         public void TestCreateConnectionUsesDefaultPort()
         {