Merge pull request #474 from paulomorgado/remove-SetPersistent

Remove deprecated IBasicProperties.SetPersistent

Author: michaelklishin

projects/client/RabbitMQ.Client/src/client/api/IBasicProperties.cs

@@ -282,21 +282,5 @@ public interface IBasicProperties : IContentHeader
         /// Returns true if the <see cref="UserId"/> UserId property is present.
         /// </summary>
         bool IsUserIdPresent();
-
-        /// <summary>Sets <see cref="DeliveryMode"/> to either persistent (2) or non-persistent (1).</summary>
-        /// <remarks>
-        /// <para>
-        /// The numbers 1 and 2 for delivery mode are "magic" in that
-        /// they appear in the AMQP 0-8 and 0-9 specifications as part
-        /// of the definition of the DeliveryMode Basic-class property,
-        /// without being defined as named constants.
-        /// </para>
-        /// <para>
-        /// Calling this method causes <see cref="DeliveryMode"/> to take on a  value.
-        /// In order to reset <see cref="DeliveryMode"/> to the default empty condition, call <see cref="ClearDeliveryMode"/> .
-        /// </para>
-        /// </remarks>
-        [Obsolete("Usage of this setter method is deprecated. Use the Persistent property instead.")]
-        void SetPersistent(bool persistent);
     }
 }

projects/client/RabbitMQ.Client/src/client/impl/BasicProperties.cs

@@ -275,25 +275,6 @@ public PublicationAddress ReplyToAddress
         /// </summary>
         public abstract bool IsUserIdPresent();
 
-        /// <summary>Sets <see cref="DeliveryMode"/> to either persistent (2) or non-persistent (1).</summary>
-        /// <remarks>
-        /// <para>
-        /// The numbers 1 and 2 for delivery mode are "magic" in that
-        /// they appear in the AMQP 0-8 and 0-9 specifications as part
-        /// of the definition of the DeliveryMode Basic-class property,
-        /// without being defined as named constants.
-        /// </para>
-        /// <para>
-        /// Calling this method causes <see cref="DeliveryMode"/> to take on a  value.
-        /// In order to reset <see cref="DeliveryMode"/> to the default empty condition, call <see cref="ClearDeliveryMode"/> .
-        /// </para>
-        /// </remarks>
-        [Obsolete("Usage of this setter method is deprecated. Use the Persistent property instead.")]
-        public void SetPersistent(bool persistent)
-        {
-            Persistent = persistent;
-        }
-
         public override object Clone()
         {
             var clone = MemberwiseClone() as BasicProperties;

projects/client/Unit/src/unit/TestBasicProperties.cs

@@ -73,37 +73,5 @@ public void TestPersistentPropertyChangesDeliveryMode_PersistentFalseDelivery1()
             Assert.AreEqual(1, subject.DeliveryMode);
             Assert.AreEqual(false, subject.Persistent);
         }
-
-
-#pragma warning disable CS0618 // Type or member is obsolete
-        [Test]
-        public void TestSetPersistentMethodChangesDeliveryMode_PersistentTrueDelivery2()
-        {
-            // Arrange
-            var subject = new Framing.BasicProperties();
-
-            // Act
-            subject.SetPersistent(true);
-
-            // Assert
-            Assert.AreEqual(2, subject.DeliveryMode);
-            Assert.AreEqual(true, subject.Persistent);
-        }
-
-
-        [Test]
-        public void TestSetPersistentMethodChangesDeliveryMode_PersistentFalseDelivery1()
-        {
-            // Arrange
-            var subject = new Framing.BasicProperties();
-
-            // Act
-            subject.SetPersistent(false);
-
-            // Assert
-            Assert.AreEqual(1, subject.DeliveryMode);
-            Assert.AreEqual(false, subject.Persistent);
-        }
-#pragma warning restore CS0618 // Type or member is obsolete
     }
 }