Skip to content

Commit ebe1265

Browse files
committed
* Fix tests
1 parent c58ff9e commit ebe1265

File tree

3 files changed

+21
-14
lines changed

3 files changed

+21
-14
lines changed

projects/Test/Integration/ConnectionRecovery/TestRpcAfterRecovery.cs

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ public async Task TestPublishRpcRightAfterReconnect()
5656
var properties = new BasicProperties();
5757
properties.ReplyTo = "amq.rabbitmq.reply-to";
5858

59-
TimeSpan doneSpan = TimeSpan.FromMilliseconds(100);
6059
var doneTcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
6160
Task closeTask = Task.Run(async () =>
6261
{
@@ -71,8 +70,12 @@ public async Task TestPublishRpcRightAfterReconnect()
7170
}
7271
});
7372

74-
while (false == doneTcs.Task.IsCompletedSuccessfully())
73+
TimeSpan doneSpan = TimeSpan.FromMilliseconds(500);
74+
DateTime start = DateTime.Now;
75+
do
7576
{
77+
await Task.Delay(doneSpan);
78+
7679
try
7780
{
7881
await _channel.BasicPublishAsync(string.Empty, testQueueName, properties, _messageBody);
@@ -86,14 +89,14 @@ public async Task TestPublishRpcRightAfterReconnect()
8689
}
8790
}
8891

89-
try
90-
{
91-
await doneTcs.Task.WaitAsync(doneSpan);
92-
}
93-
catch (TimeoutException)
92+
DateTime now = DateTime.Now;
93+
94+
if (now - start > WaitSpan)
9495
{
96+
Assert.Fail($"test exceeded wait time of {WaitSpan}");
9597
}
96-
}
98+
99+
} while (false == doneTcs.Task.IsCompletedSuccessfully());
97100

98101
await closeTask;
99102
}

projects/Test/SequentialIntegration/TestActivitySource.cs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -207,12 +207,16 @@ private void AssertActivityData(bool useRoutingKeyAsOperationName, string queueN
207207
string childName = isDeliver ? "deliver" : "receive";
208208
Activity[] activities = activityList.ToArray();
209209
Assert.NotEmpty(activities);
210-
foreach (var item in activities)
210+
211+
if (IsVerbose)
211212
{
212-
_output.WriteLine(
213-
$"{item.Context.TraceId}: {item.OperationName}");
214-
_output.WriteLine($" Tags: {string.Join(", ", item.Tags.Select(x => $"{x.Key}: {x.Value}"))}");
215-
_output.WriteLine($" Links: {string.Join(", ", item.Links.Select(x => $"{x.Context.TraceId}"))}");
213+
foreach (Activity item in activities)
214+
{
215+
_output.WriteLine(
216+
$"{item.Context.TraceId}: {item.OperationName}");
217+
_output.WriteLine($" Tags: {string.Join(", ", item.Tags.Select(x => $"{x.Key}: {x.Value}"))}");
218+
_output.WriteLine($" Links: {string.Join(", ", item.Links.Select(x => $"{x.Context.TraceId}"))}");
219+
}
216220
}
217221

218222
Activity sendActivity = activities.First(x =>

projects/Test/SequentialIntegration/TestConnectionRecovery.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public async Task TestChannelAfterDispose_GH1086()
8282

8383
void _channel_ChannelShutdown(object sender, ShutdownEventArgs e)
8484
{
85-
sawChannelShutdownTcs.SetResult(true);
85+
sawChannelShutdownTcs.TrySetResult(true);
8686
}
8787

8888
_channel.ChannelShutdown += _channel_ChannelShutdown;

0 commit comments

Comments
 (0)