Fix MQTT test flake management_plugin_connection

ansd · ansd · commit 090384fe376d · 2024-11-08T11:12:04.000+01:00
Prior to this commit this test flaked in CI:
```
=== === Reason: {assertEqual,
                     [{module,mqtt_shared_SUITE},
                      {line,1222},
                      {expression,"http_get ( Config , \"/connections\" )"},
                      {expected,[]},
                      {value,
                          [#{timeout =&gt; 99,
                             name =&gt; &lt;&lt;"127.0.0.1:58712 -&gt; 127.0.0.1:29005"&gt;&gt;,
                             node =&gt;
                                 &lt;&lt;"rmq-ct-mqtt-cluster_size_1-1-29000@localhost"&gt;&gt;,
                             port =&gt; 29005,user =&gt; &lt;&lt;"guest"&gt;&gt;,ssl =&gt; false,
                             protocol =&gt; &lt;&lt;"MQTT 5-0"&gt;&gt;,
                             host =&gt; &lt;&lt;"127.0.0.1"&gt;&gt;,
                             client_properties =&gt;
                                 #{client_id =&gt;
                                       &lt;&lt;"management_plugin_connection"&gt;&gt;},
                             vhost =&gt; &lt;&lt;"/"&gt;&gt;,peer_host =&gt; &lt;&lt;"127.0.0.1"&gt;&gt;,
                             peer_port =&gt; 58712,frame_max =&gt; 0,
                             channel_max =&gt; 0,auth_mechanism =&gt; &lt;&lt;"none"&gt;&gt;,
                             connected_at =&gt; 1730797370048,
                             ssl_protocol =&gt; null,ssl_key_exchange =&gt; null,
                             ssl_cipher =&gt; null,ssl_hash =&gt; null,
                             peer_cert_issuer =&gt; null,
                             peer_cert_subject =&gt; null,
                             peer_cert_validity =&gt; null,
                             user_who_performed_action =&gt; &lt;&lt;"guest"&gt;&gt;}]}]}
  in function  mqtt_shared_SUITE:management_plugin_connection/1 (mqtt_shared_SUITE.erl, line 1222)
  in call from test_server:ts_tc/3 (test_server.erl, line 1793)
  in call from test_server:run_test_case_eval1/6 (test_server.erl, line 1302)
  in call from test_server:run_test_case_eval/9 (test_server.erl, line 1234)
```
diff --git a/deps/rabbitmq_mqtt/test/mqtt_shared_SUITE.erl b/deps/rabbitmq_mqtt/test/mqtt_shared_SUITE.erl
@@ -1214,7 +1214,7 @@ management_plugin_connection(Config) ->
                 "/connections/" ++ binary_to_list(uri_string:quote(ConnectionName)),
                 ?NO_CONTENT),
     await_exit(C1),
-    ?assertEqual([], http_get(Config, "/connections")),
+    eventually(?_assertEqual([], http_get(Config, "/connections"))),
     eventually(?_assertEqual([], all_connection_pids(Config)), 500, 3),
 
     C2 = connect(ClientId, Config, [{keepalive, KeepaliveSecs}]),
@@ -1223,7 +1223,7 @@ management_plugin_connection(Config) ->
                 "/connections/username/guest",
                 ?NO_CONTENT),
     await_exit(C2),
-    ?assertEqual([], http_get(Config, "/connections")),
+    eventually(?_assertEqual([], http_get(Config, "/connections"))),
     eventually(?_assertEqual([], all_connection_pids(Config)), 500, 3).
 
 management_plugin_enable(Config) ->
