Update rabbitmqctl tests for rename/update cluster nodes

Author: dcorbacho

deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/rename_cluster_node_command.ex

@@ -44,9 +44,6 @@ defmodule RabbitMQ.CLI.Ctl.Commands.RenameClusterNodeCommand do
   end
 
   def banner(_, _opts) do
-    [
       "DEPRECATED. This command is a no-op. Node renaming is incompatible with Raft-based features such as quorum queues, streams, Khepri. "
-    ]
   end
-
 end

deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/update_cluster_nodes_command.ex

@@ -38,12 +38,10 @@ defmodule RabbitMQ.CLI.Ctl.Commands.UpdateClusterNodesCommand do
   def help_section(), do: :deprecated
 
   def description() do
-    "DEPRECATED. This command is a no-op. Node renaming is incompatible with Raft-based features such as quorum queues, streams, Khepri. "
+    "DEPRECATED. This command is a no-op. Node update is incompatible with Raft-based features such as quorum queues, streams, Khepri. "
   end
 
   def banner(_, _opts) do
-    [
-      "DEPRECATED. This command is a no-op. Node renaming is incompatible with Raft-based features such as quorum queues, streams, Khepri. "
-    ]
+      "DEPRECATED. This command is a no-op. Node update is incompatible with Raft-based features such as quorum queues, streams, Khepri. "
   end
-end
+end

deps/rabbitmq_cli/test/ctl/rename_cluster_node_command_test.exs

@@ -38,65 +38,8 @@ defmodule RenameClusterNodeCommandTest do
        )}
   end
 
-  test "validate: specifying no nodes fails validation", context do
-    assert @command.validate([], context[:opts]) ==
-             {:validation_failure, :not_enough_args}
-  end
-
-  test "validate: specifying one node only fails validation", context do
-    assert @command.validate(["a"], context[:opts]) ==
-             {:validation_failure, :not_enough_args}
-  end
-
-  test "validate_execution_environment: specifying an uneven number of arguments fails validation",
-       context do
-    assert match?(
-             {:validation_failure, {:bad_argument, _}},
-             @command.validate_execution_environment(["a", "b", "c"], context[:opts])
-           )
-  end
-
-  test "validate_execution_environment: request to a running node fails", _context do
-    node = get_rabbit_hostname()
-
-    assert match?(
-             {:validation_failure, :node_running},
-             @command.validate_execution_environment([to_string(node), "other_node@localhost"], %{
-               node: node
-             })
-           )
-  end
-
-  test "validate_execution_environment: not providing node data dir fails validation",
-       context do
-    opts_without_data_dir = Map.delete(context[:opts], :data_dir)
-    Application.put_env(:rabbit, :data_dir, "/tmp")
-    on_exit(fn -> Application.delete_env(:rabbit, :data_dir) end)
-
-    assert :ok ==
-             @command.validate(
-               ["some_node@localhost", "other_node@localhost"],
-               opts_without_data_dir
-             )
-
-    Application.delete_env(:rabbit, :data_dir)
-    System.put_env("RABBITMQ_MNESIA_DIR", "/tmp")
-    on_exit(fn -> System.delete_env("RABBITMQ_MNESIA_DIR") end)
-
-    assert :ok ==
-             @command.validate(
-               ["some_node@localhost", "other_node@localhost"],
-               opts_without_data_dir
-             )
-
-    System.delete_env("RABBITMQ_MNESIA_DIR")
-
-    assert :ok ==
-             @command.validate(["some_node@localhost", "other_node@localhost"], context[:opts])
-  end
-
   test "banner", context do
     assert @command.banner(["a", "b"], context[:opts]) =~
-             ~r/Renaming cluster nodes: \n a -> b/
+             ~r/DEPRECATED. This command is a no-op./
   end
 end

deps/rabbitmq_cli/test/ctl/update_cluster_nodes_command_test.exs

@@ -29,61 +29,15 @@ defmodule UpdateClusterNodesCommandTest do
      }}
   end
 
-  test "validate: providing too few arguments fails validation", context do
-    assert @command.validate([], context[:opts]) ==
-             {:validation_failure, :not_enough_args}
-  end
-
-  test "validate: providing too many arguments fails validation", context do
-    assert @command.validate(["a", "b", "c"], context[:opts]) ==
-             {:validation_failure, :too_many_args}
-  end
-
-  test "run: specifying self as seed node fails validation", context do
-    stop_rabbitmq_app()
-
+  test "run: no op", context do
     assert match?(
-             {:error, :cannot_cluster_node_with_itself},
+             :ok,
              @command.run([context[:opts][:node]], context[:opts])
            )
-
-    start_rabbitmq_app()
-  end
-
-  test "run: request to an unreachable node returns a badrpc", context do
-    opts = %{
-      node: :jake@thedog,
-      timeout: 200
-    }
-
-    assert match?(
-             {:badrpc, :nodedown},
-             @command.run([context[:opts][:node]], opts)
-           )
-  end
-
-  test "run: specifying an unreachable node as seed returns a badrpc", context do
-    stop_rabbitmq_app()
-
-    assert match?(
-             {:badrpc_multi, _, [_]},
-             @command.run([:jake@thedog], context[:opts])
-           )
-
-    start_rabbitmq_app()
   end
 
   test "banner", context do
     assert @command.banner(["a"], context[:opts]) =~
-             ~r/Will seed #{get_rabbit_hostname()} from a on next start/
-  end
-
-  test "output mnesia is running error", context do
-    exit_code = RabbitMQ.CLI.Core.ExitCodes.exit_software()
-
-    assert match?(
-             {:error, ^exit_code, "Mnesia is still running on node " <> _},
-             @command.output({:error, :mnesia_unexpectedly_running}, context[:opts])
-           )
+             ~r/DEPRECATED. This command is a no-op./
   end
 end