Skip to content

Commit 12a63a4

Browse files
author
Loïc Hoguin
committed
Remove todo
So in 2009 it was written that combining helped performance. But I doubt we ever get to a scenario where it matters to reduce the number of file_summary table entries today. There's been plenty of ets table optimisations, and this branch reduces the number of fields in entries anyway and we don't go over the whole table as often as before. See 30bc61f
1 parent e35a75c commit 12a63a4

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

deps/rabbit/src/rabbit_msg_store.erl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@
195195
%% other words, the valid data accounts for less than half the total
196196
%% size of the file), we start a garbage collection run concurrently,
197197
%% which will compact the file. This keeps utilisation high.
198-
%% @todo The comment used to claim file combining helped performance. Double check?
199198
%%
200199
%% The discovery is done periodically on files that had messages
201200
%% acked and removed. We delibirately do this lazily in order to

0 commit comments

Comments
 (0)