Refactor MQTT Java tests

Use AssertJ instead of JUnit assertions (more readable API).
Bump dependencies and clean up pom.xml.

Author: acogoluegnes

deps/rabbitmq_mqtt/test/java_SUITE_data/pom.xml

@@ -12,45 +12,63 @@
   <description>Fetches test dependencies only.</description>
   <url>https://www.rabbitmq.com</url>
 
+  <properties>
+    <paho.v5.version>[1.2.5,)</paho.v5.version>
+    <paho.v3.version>[1.2.5,)</paho.v3.version>
+    <amqp-client.version>5.18.0</amqp-client.version>
+    <junit.version>5.9.3</junit.version>
+    <assertj.version>3.24.2</assertj.version>
+    <maven-surefire-plugin.version>3.1.2</maven-surefire-plugin.version>
+    <groovy-maven-plugin.version>2.1.1</groovy-maven-plugin.version>
+    <groovy.version>2.4.21</groovy.version>
+    <maven-compiler-plugin.version>3.11.0</maven-compiler-plugin.version>
+    <spotless.version>2.37.0</spotless.version>
+    <google-java-format.version>1.17.0</google-java-format.version>
+    <test-keystore.ca>${project.build.directory}/ca.keystore</test-keystore.ca>
+    <test-keystore.password>bunnychow</test-keystore.password>
+    <groovy-scripts.dir>${basedir}/src/test/scripts</groovy-scripts.dir>
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.eclipse.paho</groupId>
       <artifactId>org.eclipse.paho.mqttv5.client</artifactId>
-      <version>1.2.5</version>
+      <version>${paho.v5.version}</version>
       <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.eclipse.paho</groupId>
       <artifactId>org.eclipse.paho.client.mqttv3</artifactId>
-      <version>[1.2.1,)</version>
+      <version>${paho.v3.version}</version>
       <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>com.rabbitmq</groupId>
       <artifactId>amqp-client</artifactId>
-      <version>5.16.0</version>
+      <version>${amqp-client.version}</version>
       <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter</artifactId>
-      <version>5.9.2</version>
+      <version>${junit.version}</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.assertj</groupId>
+      <artifactId>assertj-core</artifactId>
+      <version>${assertj.version}</version>
       <scope>test</scope>
     </dependency>
-  </dependencies>
 
-  <properties>
-    <test-keystore.ca>${project.build.directory}/ca.keystore</test-keystore.ca>
-    <test-keystore.password>bunnychow</test-keystore.password>
-    <groovy-scripts.dir>${basedir}/src/test/scripts</groovy-scripts.dir>
-  </properties>
+  </dependencies>
 
   <build>
       <plugins>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-surefire-plugin</artifactId>
-          <version>2.22.2</version>
+          <version>${maven-surefire-plugin.version}</version>
           <configuration>
             <environmentVariables>
               <DEPS_DIR>${deps.dir}</DEPS_DIR>
@@ -79,12 +97,12 @@
         <plugin>
           <groupId>org.codehaus.gmaven</groupId>
           <artifactId>groovy-maven-plugin</artifactId>
-          <version>2.1.1</version>
+          <version>${groovy-maven-plugin.version}</version>
           <dependencies>
             <dependency>
               <groupId>org.codehaus.groovy</groupId>
               <artifactId>groovy-all</artifactId>
-              <version>2.4.17</version>
+              <version>${groovy.version}</version>
             </dependency>
           </dependencies>
           <executions>
@@ -127,7 +145,7 @@
 
         <plugin>
           <artifactId>maven-compiler-plugin</artifactId>
-          <version>3.8.1</version>
+          <version>${maven-compiler-plugin.version}</version>
           <configuration>
             <source>1.8</source>
             <target>1.8</target>
@@ -138,6 +156,30 @@
           </configuration>
         </plugin>
 
+        <plugin>
+          <groupId>com.diffplug.spotless</groupId>
+          <artifactId>spotless-maven-plugin</artifactId>
+          <version>${spotless.version}</version>
+          <configuration>
+            <java>
+              <googleJavaFormat>
+                <version>${google-java-format.version}</version>
+                <style>GOOGLE</style>
+              </googleJavaFormat>
+            </java>
+            <!--          <ratchetFrom>origin/main</ratchetFrom>-->
+            <licenseHeader> <!-- specify either content or file, but not both -->
+              <content>// This Source Code Form is subject to the terms of the Mozilla Public
+                // License, v. 2.0. If a copy of the MPL was not distributed with this
+                // file, You can obtain one at https://mozilla.org/MPL/2.0/.
+                //
+                //  Copyright (c) 2007-2023 VMware, Inc. or its affiliates.  All rights reserved.
+                //
+              </content>
+            </licenseHeader>
+          </configuration>
+        </plugin>
+
       </plugins>
   </build>
 </project>