Skip to content

Commit 3486206

Browse files
committed
Skip flaky mixed version test
``` bazel test //deps/rabbit:amqp_client_SUITE-mixed -t- --test_sharding_strategy=disabled --test_env FOCUS="-group [cluster_size_3] -case async_notify_unsettled_classic_queue" --config=rbe-26 --runs_per_test=40 ``` was failing 8 out of 40 times. Skip this test as we know that link flow control with classic queues is broken in 3.13: #2597 Credit API v2 in RabbitMQ 4.0 fixes this bug.
1 parent 2815c71 commit 3486206

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

deps/rabbit/test/amqp_client_SUITE.erl

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2230,11 +2230,13 @@ async_notify_settled_stream(Config) ->
22302230
async_notify(settled, <<"stream">>, Config).
22312231

22322232
async_notify_unsettled_classic_queue(Config) ->
2233-
%% TODO Bump old version in mixed version tests to 3.13.x,
2234-
%% require ff message_containers and always run this test case.
2235-
case rabbit_ct_broker_helpers:enable_feature_flag(Config, message_containers) of
2236-
ok -> async_notify(unsettled, <<"classic">>, Config);
2237-
{skip, _} = Skip -> Skip
2233+
case rabbit_ct_broker_helpers:enable_feature_flag(Config, credit_api_v2) of
2234+
ok ->
2235+
async_notify(unsettled, <<"classic">>, Config);
2236+
{skip, _} ->
2237+
{skip, "Skipping as this test will flake. Link flow control in classic "
2238+
"queues with credit API v1 is known to be broken: "
2239+
"https://github.com/rabbitmq/rabbitmq-server/issues/2597"}
22382240
end.
22392241

22402242
async_notify_unsettled_quorum_queue(Config) ->

0 commit comments

Comments
 (0)