Skip to content

Commit 34f42f7

Browse files
Use EUnit assertions here
They produce more informative match failure reports.
1 parent c5a55c9 commit 34f42f7

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

test/queue_master_location_SUITE.erl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434

3535
-include_lib("common_test/include/ct.hrl").
3636
-include_lib("amqp_client/include/amqp_client.hrl").
37+
-include_lib("eunit/include/eunit.hrl").
3738

3839
-compile(export_all).
3940

@@ -251,21 +252,20 @@ declare(Config, QueueName, Durable, AutoDelete, Args, Owner) ->
251252
verify_min_master(Config, Q) ->
252253
Node = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename),
253254
MinMaster = min_master_node(Config),
254-
ct:pal("Expecting min master ~p~n", [MinMaster]),
255-
{ok, MinMaster} = rpc:call(Node, rabbit_queue_master_location_misc,
256-
lookup_master, [Q, ?DEFAULT_VHOST_PATH]).
255+
?assertEqual({ok, MinMaster}, rpc:call(Node, rabbit_queue_master_location_misc,
256+
lookup_master, [Q, ?DEFAULT_VHOST_PATH])).
257257

258258
verify_random(Config, Q) ->
259259
[Node | _] = Nodes = rabbit_ct_broker_helpers:get_node_configs(Config,
260260
nodename),
261261
{ok, Master} = rpc:call(Node, rabbit_queue_master_location_misc,
262262
lookup_master, [Q, ?DEFAULT_VHOST_PATH]),
263-
true = lists:member(Master, Nodes).
263+
?assert(lists:member(Master, Nodes)).
264264

265265
verify_client_local(Config, Q) ->
266266
Node = rabbit_ct_broker_helpers:get_node_config(Config, 0, nodename),
267-
{ok, Node} = rpc:call(Node, rabbit_queue_master_location_misc,
268-
lookup_master, [Q, ?DEFAULT_VHOST_PATH]).
267+
?assertEqual({ok, Node}, rpc:call(Node, rabbit_queue_master_location_misc,
268+
lookup_master, [Q, ?DEFAULT_VHOST_PATH])).
269269

270270
set_location_policy(Config, Name, Strategy) ->
271271
ok = rabbit_ct_broker_helpers:set_policy(Config, 0,

0 commit comments

Comments
 (0)