Skip to content

Commit 553b6ec

Browse files
the-mikedavismergify[bot]
authored andcommitted
Skip cluster_minority_SUITE when RABBITMQ_METADATA_STORE is set to mnesia
This suite is only meant to run with Khepri as the metadata store. Instead of setting this explicitly we can look at the configured metadata store and conditionally skip the entire suite. This prevents these tests from running twice in CI. (cherry picked from commit ecb7575)
1 parent 2cbda21 commit 553b6ec

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

deps/rabbit/test/cluster_minority_SUITE.erl

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,20 @@ suite() ->
5555
%% Testsuite setup/teardown.
5656
%% -------------------------------------------------------------------
5757

58-
init_per_suite(Config0) ->
58+
init_per_suite(Config) ->
5959
rabbit_ct_helpers:log_environment(),
60-
Config = rabbit_ct_helpers:set_config(Config0, [{metadata_store, khepri}]),
61-
rabbit_ct_helpers:run_setup_steps(Config,
62-
[
63-
fun rabbit_ct_broker_helpers:configure_dist_proxy/1
64-
]).
60+
case rabbit_ct_broker_helpers:configured_metadata_store(Config) of
61+
mnesia ->
62+
%% This SUITE is meant to test how Khepri behaves in a minority,
63+
%% so mnesia should be skipped.
64+
{skip, "Minority testing not supported by mnesia"};
65+
_ ->
66+
rabbit_ct_helpers:run_setup_steps(
67+
Config,
68+
[
69+
fun rabbit_ct_broker_helpers:configure_dist_proxy/1
70+
])
71+
end.
6572

6673
end_per_suite(Config) ->
6774
rabbit_ct_helpers:run_teardown_steps(Config).

0 commit comments

Comments
 (0)