Use infinity as config instead of 0

Author: SimonUnge

deps/rabbit/priv/schema/rabbit.schema

@@ -890,7 +890,19 @@ end}.
 {mapping, "channel_max", "rabbit.channel_max", [{datatype, integer}]}.
 
 {mapping, "channel_max_per_node", "rabbit.channel_max_per_node",
-          [{datatype, integer}, {validators, ["non_negative_integer"]}]}.
+  [{datatype, [{atom, infinity}, integer]}]}.
+
+{translation, "rabbit.channel_max_per_node",
+ fun(Conf) ->
+  case cuttlefish:conf_get("channel_max_per_node", Conf, undefined) of
+      undefined -> cuttlefish:unset();
+      infinity  -> infinity;
+      Val when is_integer(Val) andalso Val > 0 -> Val;
+      _         -> cuttlefish:invalid("should be positive integer or 'infinity'")
+  end
+ end
+}.
+
 
 %% Set the max permissible number of client connections per node.
 %% `infinity` means "no limit".

deps/rabbit/src/rabbit_reader.erl

@@ -942,8 +942,8 @@ is_over_limits(Username) ->
     end.
 
 is_over_node_channel_limit() ->
-    case rabbit_misc:get_env(rabbit, channel_max_per_node, 0) of
-        0 ->
+    case rabbit_misc:get_env(rabbit, channel_max_per_node, infinity) of
+        infinity ->
             false;
         NodeLimit ->
             %% Only fetch this if a limit is set

deps/rabbit/test/config_schema_SUITE_data/rabbit.snippets

@@ -400,6 +400,10 @@ tcp_listen_options.exit_on_close = false",
   "channel_max_per_node = 16",
   [{rabbit,[{channel_max_per_node, 16}]}],
   []},
+ {channel_max_per_node,
+  "channel_max_per_node = infinity",
+  [{rabbit,[{channel_max_per_node, infinity}]}],
+  []},
  {max_message_size,
   "max_message_size = 131072",
   [{rabbit, [{max_message_size, 131072}]}],