Use tracked connection ID in error message

Author: lukebakken

src/rabbit_connection_tracking_handler.erl

@@ -53,24 +53,24 @@ handle_event(#event{type = connection_created, props = Details}, State) ->
     ThisNode = node(),
     case pget(node, Details) of
         ThisNode ->
+            TConn = rabbit_connection_tracking:tracked_connection_from_connection_created(Details),
+            ConnId = TConn#tracked_connection.id,
             try
-                rabbit_connection_tracking:register_connection(
-                    rabbit_connection_tracking:tracked_connection_from_connection_created(Details)
-                )
+                rabbit_connection_tracking:register_connection(TConn)
             catch
                 error:{no_exists, _} ->
                     Msg = "Could not register connection ~p for tracking, "
                           "its table is not ready yet or the connection terminated prematurely",
-                    rabbit_log_connection:warning(Msg, [pget(pid, Details)]),
+                    rabbit_log_connection:warning(Msg, [ConnId]),
                     ok;
                 error:Err ->
                     Msg = "Could not register connection ~p for tracking: ~p",
-                    rabbit_log_connection:warning(Msg, [pget(pid, Details), Err]),
+                    rabbit_log_connection:warning(Msg, [ConnId, Err]),
                     ok
             end;
-      _OtherNode ->
-        %% ignore
-        ok
+        _OtherNode ->
+            %% ignore
+            ok
     end,
     {ok, State};
 handle_event(#event{type = connection_closed, props = Details}, State) ->