Skip to content

Commit 671145d

Browse files
committed
Move schema dir creation to the point it's going to be used.
On startup some environments do not expect schema dir if they use the old config. The script might fail with an error, while there is no reason to.
1 parent ecf000f commit 671145d

File tree

3 files changed

+36
-36
lines changed

3 files changed

+36
-36
lines changed

scripts/rabbitmq-server

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,6 @@ RABBITMQ_EBIN_ROOT="${RABBITMQ_HOME}/ebin"
6262

6363
[ "$NOTIFY_SOCKET" ] && RUNNING_UNDER_SYSTEMD=true
6464

65-
if [ ! -d ${RABBITMQ_SCHEMA_DIR} ]; then
66-
mkdir -p "${RABBITMQ_SCHEMA_DIR}"
67-
fi
68-
69-
if [ ! -d ${RABBITMQ_GENERATED_CONFIG_DIR} ]; then
70-
mkdir -p "${RABBITMQ_GENERATED_CONFIG_DIR}"
71-
fi
72-
73-
if [ ! -f "${RABBITMQ_SCHEMA_DIR}/rabbit.schema" ]; then
74-
cp "${RABBITMQ_HOME}/priv/schema/rabbit.schema" "${RABBITMQ_SCHEMA_DIR}"
75-
fi
76-
7765
get_noex() {
7866
if [ "x" = "x${1}" ]; then
7967
echo ""
@@ -164,6 +152,18 @@ fi
164152

165153
# Set -conf and other generated config parameters
166154
if [ "${RABBITMQ_CONFIG_FILE_NOEX}.conf" = "${RABBITMQ_CONFIG_FILE}" ]; then
155+
if [ ! -d ${RABBITMQ_SCHEMA_DIR} ]; then
156+
mkdir -p "${RABBITMQ_SCHEMA_DIR}"
157+
fi
158+
159+
if [ ! -d ${RABBITMQ_GENERATED_CONFIG_DIR} ]; then
160+
mkdir -p "${RABBITMQ_GENERATED_CONFIG_DIR}"
161+
fi
162+
163+
if [ ! -f "${RABBITMQ_SCHEMA_DIR}/rabbit.schema" ]; then
164+
cp "${RABBITMQ_HOME}/priv/schema/rabbit.schema" "${RABBITMQ_SCHEMA_DIR}"
165+
fi
166+
167167
RABBITMQ_GENERATED_CONFIG_ARG="-conf ${RABBITMQ_CONFIG_FILE} \
168168
-conf_dir ${RABBITMQ_GENERATED_CONFIG_DIR} \
169169
-conf_script_dir `dirname $0` \

scripts/rabbitmq-server.bat

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -48,18 +48,6 @@ if not exist "!ERLANG_HOME!\bin\erl.exe" (
4848

4949
set RABBITMQ_EBIN_ROOT=!RABBITMQ_HOME!\ebin
5050

51-
if not exist "!RABBITMQ_SCHEMA_DIR!" (
52-
mkdir "!RABBITMQ_SCHEMA_DIR!"
53-
)
54-
55-
if not exist "!RABBITMQ_GENERATED_CONFIG_DIR!" (
56-
mkdir "!RABBITMQ_GENERATED_CONFIG_DIR!"
57-
)
58-
59-
if not exist "!RABBITMQ_SCHEMA_DIR!\rabbit.schema" (
60-
copy "!RABBITMQ_HOME!\priv\schema\rabbit.schema" "!RABBITMQ_SCHEMA_DIR!\rabbit.schema"
61-
)
62-
6351
CALL :get_noex !RABBITMQ_ADVANCED_CONFIG_FILE! RABBITMQ_ADVANCED_CONFIG_FILE_NOEX
6452

6553
if "!RABBITMQ_ADVANCED_CONFIG_FILE!" == "!RABBITMQ_ADVANCED_CONFIG_FILE_NOEX!" (
@@ -134,6 +122,18 @@ if exist !RABBITMQ_CONFIG_ARG_FILE! (
134122

135123
rem Set -conf and other generated config parameters
136124
if "!RABBITMQ_CONFIG_FILE_NOEX!.conf" == "!RABBITMQ_CONFIG_FILE!" (
125+
if not exist "!RABBITMQ_SCHEMA_DIR!" (
126+
mkdir "!RABBITMQ_SCHEMA_DIR!"
127+
)
128+
129+
if not exist "!RABBITMQ_GENERATED_CONFIG_DIR!" (
130+
mkdir "!RABBITMQ_GENERATED_CONFIG_DIR!"
131+
)
132+
133+
if not exist "!RABBITMQ_SCHEMA_DIR!\rabbit.schema" (
134+
copy "!RABBITMQ_HOME!\priv\schema\rabbit.schema" "!RABBITMQ_SCHEMA_DIR!\rabbit.schema"
135+
)
136+
137137
set RABBITMQ_GENERATED_CONFIG_ARG=-conf "!RABBITMQ_CONFIG_FILE!" ^
138138
-conf_dir "!RABBITMQ_GENERATED_CONFIG_DIR!" ^
139139
-conf_script_dir !CONF_SCRIPT_DIR:\=/! ^

scripts/rabbitmq-service.bat

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -131,18 +131,6 @@ if errorlevel 1 (
131131

132132
set RABBITMQ_EBIN_ROOT=!RABBITMQ_HOME!\ebin
133133

134-
if not exist "!RABBITMQ_SCHEMA_DIR!" (
135-
mkdir "!RABBITMQ_SCHEMA_DIR!"
136-
)
137-
138-
if not exist "!RABBITMQ_GENERATED_CONFIG_DIR!" (
139-
mkdir "!RABBITMQ_GENERATED_CONFIG_DIR!"
140-
)
141-
142-
if not exist "!RABBITMQ_SCHEMA_DIR!\rabbit.schema" (
143-
copy "!RABBITMQ_HOME!\priv\schema\rabbit.schema" "!RABBITMQ_SCHEMA_DIR!\rabbit.schema"
144-
)
145-
146134
CALL :get_noex !RABBITMQ_ADVANCED_CONFIG_FILE! RABBITMQ_ADVANCED_CONFIG_FILE_NOEX
147135

148136
if "!RABBITMQ_ADVANCED_CONFIG_FILE!" == "!RABBITMQ_ADVANCED_CONFIG_FILE_NOEX!" (
@@ -217,6 +205,18 @@ if exist !RABBITMQ_CONFIG_ARG_FILE! (
217205

218206
rem Set -conf and other generated config parameters
219207
if "!RABBITMQ_CONFIG_FILE_NOEX!.conf" == "!RABBITMQ_CONFIG_FILE!" (
208+
if not exist "!RABBITMQ_SCHEMA_DIR!" (
209+
mkdir "!RABBITMQ_SCHEMA_DIR!"
210+
)
211+
212+
if not exist "!RABBITMQ_GENERATED_CONFIG_DIR!" (
213+
mkdir "!RABBITMQ_GENERATED_CONFIG_DIR!"
214+
)
215+
216+
if not exist "!RABBITMQ_SCHEMA_DIR!\rabbit.schema" (
217+
copy "!RABBITMQ_HOME!\priv\schema\rabbit.schema" "!RABBITMQ_SCHEMA_DIR!\rabbit.schema"
218+
)
219+
220220
set RABBITMQ_GENERATED_CONFIG_ARG=-conf "!RABBITMQ_CONFIG_FILE!" ^
221221
-conf_dir "!RABBITMQ_GENERATED_CONFIG_DIR!" ^
222222
-conf_script_dir !CONF_SCRIPT_DIR:\=/! ^

0 commit comments

Comments
 (0)