Speed up shovel start and cleanup

The filtering was incorrect, so we ended up trying to delete
all existing shovels. Running shovels would reject the attempt,
so things generally worked as expected, but this redundant work
was quite costly.

In a test with 1000 shovels, this change speeds up a definition import
from a few minutes to a few seconds.

Fixes https://github.com/rabbitmq/rabbitmq-server/discussions/9714
Fixes #8364

(cherry picked from commit 015be93)

# Conflicts:
#	deps/rabbitmq_shovel/src/rabbit_shovel_dyn_worker_sup_sup.erl

Author: mkuratczyk

deps/rabbitmq_shovel/src/rabbit_shovel_dyn_worker_sup_sup.erl

@@ -83,10 +83,18 @@ stop_child({VHost, ShovelName} = Name) ->
 %% See rabbit_shovel_worker:terminate/2
 
 cleanup_specs() ->
+<<<<<<< HEAD
     SpecsSet = sets:from_list([element(1, S) || S <- mirrored_supervisor:which_children(?SUPERVISOR)]),
     ParamsSet = sets:from_list(rabbit_runtime_parameters:list_component(<<"shovel">>)),
     F = fun(Spec, ok) ->
             _ = mirrored_supervisor:delete_child(?SUPERVISOR, Spec),
+=======
+    SpecsSet = sets:from_list([element(2, element(1, S)) || S <- mirrored_supervisor:which_children(?SUPERVISOR)]),
+    ParamsSet = sets:from_list([ {proplists:get_value(vhost, S), proplists:get_value(name, S)}
+                                 || S <- rabbit_runtime_parameters:list_component(<<"shovel">>) ]),
+    F = fun(Name, ok) ->
+            _ = mirrored_supervisor:delete_child(?SUPERVISOR, id(Name)),
+>>>>>>> 015be9336c (Speed up shovel start and cleanup)
             ok
         end,
     ok = sets:fold(F, ok, sets:subtract(SpecsSet, ParamsSet)).