Fix compiler warnings

Author: HoloRin

deps/rabbitmq_amqp1_0/src/rabbit_amqp1_0_reader.erl

@@ -279,13 +279,13 @@ error_frame(Condition, Fmt, Args) ->
 
 handle_exception(State = #v1{connection_state = closed}, Channel,
                  #'v1_0.error'{description = {utf8, Desc}}) ->
-    rabbit_log_connection:error("AMQP 1.0 connection ~p (~p), channel ~p - error:~n~p~n",
+    _ = rabbit_log_connection:error("AMQP 1.0 connection ~p (~p), channel ~p - error:~n~p~n",
         [self(), closed, Channel, Desc]),
     State;
 handle_exception(State = #v1{connection_state = CS}, Channel,
                  ErrorFrame = #'v1_0.error'{description = {utf8, Desc}})
   when ?IS_RUNNING(State) orelse CS =:= closing ->
-    rabbit_log_connection:error("AMQP 1.0 connection ~p (~p), channel ~p - error:~n~p~n",
+    _ = rabbit_log_connection:error("AMQP 1.0 connection ~p (~p), channel ~p - error:~n~p~n",
         [self(), CS, Channel, Desc]),
     %% TODO: session errors shouldn't force the connection to close
     State1 = close_connection(State),
@@ -421,8 +421,8 @@ handle_1_0_connection_frame(#'v1_0.open'{ max_frame_size = ClientFrameMax,
                     undefined -> undefined;
                     {utf8, Val} -> Val
                   end,
-    rabbit_log:debug("AMQP 1.0 connection.open frame: hostname = ~s, extracted vhost = ~s, idle_timeout = ~p" ,
-                    [HostnameVal, vhost(Hostname), HeartbeatSec * 1000]),
+    _ = rabbit_log:debug("AMQP 1.0 connection.open frame: hostname = ~s, extracted vhost = ~s, idle_timeout = ~p" ,
+                         [HostnameVal, vhost(Hostname), HeartbeatSec * 1000]),
     %% TODO enforce channel_max
     ok = send_on_channel0(
            Sock,
@@ -715,7 +715,7 @@ send_to_new_1_0_session(Channel, Frame, State) ->
             put({ch_fr_pid, ChFrPid}, {channel, Channel}),
             ok = rabbit_amqp1_0_session:process_frame(ChFrPid, Frame);
         {error, {not_allowed, _}} ->
-            rabbit_log:error("AMQP 1.0: user '~s' is not allowed to access virtual host '~s'",
+            _ = rabbit_log:error("AMQP 1.0: user '~s' is not allowed to access virtual host '~s'",
                 [User#user.username, vhost(Hostname)]),
             %% Let's skip the supervisor trace, this is an expected error
             throw({error, {not_allowed, User#user.username}});

deps/rabbitmq_amqp1_0/src/rabbit_amqp1_0_session_process.erl

@@ -57,13 +57,13 @@ init({Channel, ReaderPid, WriterPid, #user{username = Username}, VHost,
                                 session            = rabbit_amqp1_0_session:init(Channel)
                                }};
                 {error, Reason} ->
-                    rabbit_log:warning("Closing session for connection ~p:~n~p~n",
-                                       [ReaderPid, Reason]),
+                    _ = rabbit_log:warning("Closing session for connection ~p:~n~p~n",
+                                           [ReaderPid, Reason]),
                     {stop, Reason}
             end;
         {error, Reason} ->
-            rabbit_log:warning("Closing session for connection ~p:~n~p~n",
-                               [ReaderPid, Reason]),
+            _ = rabbit_log:warning("Closing session for connection ~p:~n~p~n",
+                                   [ReaderPid, Reason]),
             {stop, Reason}
     end.
 
@@ -94,8 +94,8 @@ handle_info({#'basic.deliver'{ consumer_tag = ConsumerTag,
     case get({out, Handle}) of
         undefined ->
             %% TODO handle missing link -- why does the queue think it's there?
-            rabbit_log:warning("Delivery to non-existent consumer ~p",
-                               [ConsumerTag]),
+            _ = rabbit_log:warning("Delivery to non-existent consumer ~p",
+                                   [ConsumerTag]),
             {noreply, State};
         Link ->
             {ok, Frames, Session1} =
@@ -158,8 +158,8 @@ handle_info({'DOWN', _MRef, process, Ch, Reason},
                                              io_lib:format("~w", [Reason])))}}
     end,
     End = #'v1_0.end'{ error = Error },
-    rabbit_log:warning("Closing session for connection ~p:~n~p~n",
-                       [ReaderPid, Reason]),
+    _ = rabbit_log:warning("Closing session for connection ~p:~n~p~n",
+                           [ReaderPid, Reason]),
     ok = rabbit_amqp1_0_writer:send_command_sync(Sock, End),
     {stop, normal, State};
 handle_info({'DOWN', _MRef, process, _QPid, _Reason}, State) ->
@@ -186,8 +186,8 @@ handle_cast({frame, Frame, FlowPid},
     catch exit:Reason = #'v1_0.error'{} ->
             %% TODO shut down nicely like rabbit_channel
             End = #'v1_0.end'{ error = Reason },
-            rabbit_log:warning("Closing session for connection ~p:~n~p~n",
-                               [ReaderPid, Reason]),
+            _ = rabbit_log:warning("Closing session for connection ~p:~n~p~n",
+                                   [ReaderPid, Reason]),
             ok = rabbit_amqp1_0_writer:send_command_sync(Sock, End),
             {stop, normal, State};
           exit:normal ->
@@ -320,7 +320,7 @@ handle_control(Flow = #'v1_0.flow'{},
                 undefined ->
                     case get({out, Handle}) of
                         undefined ->
-                            rabbit_log:warning("Flow for unknown link handle ~p", [Flow]),
+                            _ = rabbit_log:warning("Flow for unknown link handle ~p", [Flow]),
                             protocol_error(?V_1_0_AMQP_ERROR_INVALID_FIELD,
                                            "Unattached handle: ~p", [Handle]);
                         Out ->

deps/rabbitmq_shovel/src/rabbit_shovel_dyn_worker_sup_sup.erl

@@ -36,10 +36,10 @@ adjust(Name, Def) ->
     start_child(Name, Def).
 
 start_child({VHost, ShovelName} = Name, Def) ->
-    rabbit_log_shovel:debug("Asked to start a dynamic Shovel named '~s' in virtual host '~s'", [ShovelName, VHost]),
+    _ = rabbit_log_shovel:debug("Asked to start a dynamic Shovel named '~s' in virtual host '~s'", [ShovelName, VHost]),
     LockId = rabbit_shovel_locks:lock(Name),
     cleanup_specs(),
-    rabbit_log_shovel:debug("Starting a mirrored supervisor named '~s' in virtual host '~s'", [ShovelName, VHost]),
+    _ = rabbit_log_shovel:debug("Starting a mirrored supervisor named '~s' in virtual host '~s'", [ShovelName, VHost]),
     Result = case mirrored_supervisor:start_child(
            ?SUPERVISOR,
            {Name, {rabbit_shovel_dyn_worker_sup, start_link, [Name, Def]},
@@ -56,7 +56,7 @@ child_exists(Name) ->
               mirrored_supervisor:which_children(?SUPERVISOR)).
 
 stop_child({VHost, ShovelName} = Name) ->
-    rabbit_log_shovel:debug("Asked to stop a dynamic Shovel named '~s' in virtual host '~s'", [ShovelName, VHost]),
+    _ = rabbit_log_shovel:debug("Asked to stop a dynamic Shovel named '~s' in virtual host '~s'", [ShovelName, VHost]),
     LockId = rabbit_shovel_locks:lock(Name),
     case get({shovel_worker_autodelete, Name}) of
         true -> ok; %% [1]