Peer discovery AWS, K8S: more Dialyzer fixes

Author: michaelklishin

deps/rabbit_common/src/rabbit_peer_discovery_backend.erl

@@ -54,6 +54,6 @@
 
 -callback lock(Node :: atom())   -> {ok, Data :: term()} | not_supported | {error, Reason :: string()}.
 
--callback unlock(Data :: term()) -> ok | {error, Reason :: string()}.
+-callback unlock(Data :: term()) -> ok.
 
 -optional_callbacks([init/0]).

deps/rabbitmq_peer_discovery_aws/src/rabbit_peer_discovery_aws.erl

@@ -143,16 +143,15 @@ lock(Node) ->
       Error
   end.
 
--spec unlock({{ResourceId :: string(), LockRequesterId :: node()}, Nodes :: [node()]}) ->
-    ok | {error, Reason :: string()}.
-
+-spec unlock({{ResourceId :: string(), LockRequestedId :: atom()}, Nodes :: [atom()]}) -> 'ok'.
 unlock({LockId, Nodes}) ->
   global:del_lock(LockId, Nodes),
   ok.
 
 %%
 %% Implementation
 %%
+
 -spec get_config_key(Key :: atom(), Map :: #{atom() => peer_discovery_config_value()})
                     -> peer_discovery_config_value().
 

deps/rabbitmq_peer_discovery_aws/src/rabbitmq_peer_discovery_aws.erl

@@ -49,6 +49,6 @@ post_registration() ->
 lock(Node) ->
     ?DELEGATE:lock(Node).
 
--spec unlock({ResourceId :: string(), LockRequesterId :: node()}) -> ok | {error, Reason :: string()}.
+-spec unlock({{ResourceId :: string(), LockRequestedId :: atom()}, Nodes :: [atom()]}) -> 'ok'.
 unlock(Data) ->
     ?DELEGATE:unlock(Data).

deps/rabbitmq_peer_discovery_common/include/rabbit_peer_discovery.hrl

@@ -16,7 +16,7 @@
 % by `httpc`
 -define(DEFAULT_HTTP_TIMEOUT, 2250).
 
--type peer_discovery_config_value() :: atom() | integer() | string() | undefined.
+-type peer_discovery_config_value() :: atom() | integer() | string() | list() | map() | any() | undefined.
 
 -record(peer_discovery_config_entry_meta,
         {env_variable  :: string(),

deps/rabbitmq_peer_discovery_k8s/src/rabbit_peer_discovery_k8s.erl

@@ -96,9 +96,7 @@ lock(Node) ->
       Error
   end.
 
--spec unlock({{ResourceId :: string(), LockRequesterId :: node()}, Nodes :: [node()]}) ->
-    ok | {error, Reason :: string()}.
-
+-spec unlock({{ResourceId :: string(), LockRequestedId :: atom()}, Nodes :: [atom()]}) -> 'ok'.
 unlock({LockId, Nodes}) ->
     global:del_lock(LockId, Nodes),
     ok.

deps/rabbitmq_peer_discovery_k8s/src/rabbitmq_peer_discovery_k8s.erl

@@ -48,7 +48,7 @@ post_registration() ->
 lock(Node) ->
     ?DELEGATE:lock(Node).
 
--spec unlock({ResourceId :: string(), LockRequesterId :: node()}) -> ok | {error, Reason :: string()}.
+-spec unlock({{ResourceId :: string(), LockRequestedId :: atom()}, Nodes :: [atom()]}) -> 'ok'.
 unlock(Data) ->
     ?DELEGATE:unlock(Data).