Skip to content

Commit 862b239

Browse files
MarcialRosalesmergify[bot]
authored andcommitted
Add missing function that
checks if element is not visible (cherry picked from commit 8b0589b) (cherry picked from commit f18d0e6)
1 parent 15443b1 commit 862b239

File tree

3 files changed

+25
-1
lines changed

3 files changed

+25
-1
lines changed

selenium/test/oauth/with-idp-down/landing.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ describe('When UAA is down', function () {
2626

2727
it('should not be presented with a login button to log in', async function () {
2828
await homePage.isLoaded()
29-
assert.equal(false, await homePage.isLoginButtonVisible())
29+
assert.ok(await homePage.isLoginButtonNotVisible())
3030
})
3131

3232
after(async function () {

selenium/test/pageobjects/BasePage.js

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,27 @@ module.exports = class BasePage {
162162
})
163163
*/
164164
}
165+
166+
async isPopupWarningNotDisplayed() {
167+
return this.isElementNotVisible(FORM_POPUP)
168+
}
169+
170+
async isElementNotVisible(locator) {
171+
try {
172+
await this.driver.wait(async() => {
173+
try {
174+
const element = await this.driver.findElement(locator)
175+
const visible = await element.isDisplayed()
176+
return !visible
177+
} catch (error) {
178+
return true
179+
}
180+
}, this.timeout)
181+
return true
182+
} catch (error) {
183+
return false
184+
}
185+
}
165186
async getPopupWarning() {
166187
let element = await driver.findElement(FORM_POPUP)
167188
return this.driver.wait(until.elementIsVisible(element), this.timeout,

selenium/test/pageobjects/SSOHomePage.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ module.exports = class SSOHomePage extends BasePage {
5151
async getOAuthResourceOptions () {
5252
return this.getSelectableOptions(SELECT_RESOURCES)
5353
}
54+
async isLoginButtonNotVisible() {
55+
return this.isElementNotVisible(OAUTH2_LOGIN_BUTTON)
56+
}
5457
async isLoginButtonVisible() {
5558
try {
5659
await this.waitForDisplayed(OAUTH2_LOGIN_BUTTON)

0 commit comments

Comments
 (0)