Skip to content

Commit 8a0f7c8

Browse files
committed
Revert "verify_none in a couple of tests"
This reverts commit a6cde4e.
1 parent a6cde4e commit 8a0f7c8

File tree

6 files changed

+9
-19
lines changed

6 files changed

+9
-19
lines changed

deps/rabbitmq_amqp1_0/test/proxy_protocol_SUITE.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ proxy_protocol_tls(Config) ->
7474
{ok, Socket} = gen_tcp:connect({127,0,0,1}, Port,
7575
[binary, {active, false}, {packet, raw}]),
7676
ok = inet:send(Socket, "PROXY TCP4 192.168.1.1 192.168.1.2 80 81\r\n"),
77-
{ok, SslSocket} = ssl:connect(Socket, [{verify, verify_none}], ?TIMEOUT),
77+
{ok, SslSocket} = ssl:connect(Socket, [], ?TIMEOUT),
7878
[ok = ssl:send(SslSocket, amqp_1_0_frame(FrameType))
7979
|| FrameType <- [header_sasl, sasl_init, header_amqp, open, 'begin']],
8080
{ok, _Packet} = ssl:recv(SslSocket, 0, ?TIMEOUT),

deps/rabbitmq_mqtt/test/proxy_protocol_SUITE.erl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ proxy_protocol_tls(Config) ->
7878
{ok, Socket} = gen_tcp:connect({127,0,0,1}, Port,
7979
[binary, {active, false}, {packet, raw}]),
8080
ok = inet:send(Socket, "PROXY TCP4 192.168.1.1 192.168.1.2 80 81\r\n"),
81-
{ok, SslSocket} = ssl:connect(Socket, [{verify, verify_none}], ?TIMEOUT),
82-
ok = ssl:send(SslSocket, mqtt_3_1_1_connect_packet()),
81+
{ok, SslSocket} = ssl:connect(Socket, [], ?TIMEOUT),
82+
ok = ssl:send(SslSocket, mqtt_3_1_1_connect_frame()),
8383
{ok, _Packet} = ssl:recv(SslSocket, 0, ?TIMEOUT),
8484
ConnectionName = rabbit_ct_broker_helpers:rpc(Config, 0,
8585
?MODULE, connection_name, []),

deps/rabbitmq_stomp/test/proxy_protocol_SUITE.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ proxy_protocol_tls(Config) ->
7878
{ok, Socket} = gen_tcp:connect({127,0,0,1}, Port,
7979
[binary, {active, false}, {packet, raw}]),
8080
ok = inet:send(Socket, "PROXY TCP4 192.168.1.1 192.168.1.2 80 81\r\n"),
81-
{ok, SslSocket} = ssl:connect(Socket, [{verify, verify_none}], ?TIMEOUT),
81+
{ok, SslSocket} = ssl:connect(Socket, [], ?TIMEOUT),
8282
ok = ssl:send(SslSocket, stomp_connect_frame()),
8383
{ok, _Packet} = ssl:recv(SslSocket, 0, ?TIMEOUT),
8484
ConnectionName = rabbit_ct_broker_helpers:rpc(Config, 0,

deps/rabbitmq_stream/test/commands_SUITE.erl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -769,13 +769,9 @@ start_stream_tls_connection(Port) ->
769769
start_stream_connection(ssl, Port).
770770

771771
start_stream_connection(Transport, Port) ->
772-
TlsOpts = case Transport of
773-
ssl -> [{verify, verify_none}];
774-
_ -> []
775-
end,
776772
{ok, S} =
777773
Transport:connect("localhost", Port,
778-
[{active, false}, {mode, binary}] ++ TlsOpts),
774+
[{active, false}, {mode, binary}]),
779775
C0 = rabbit_stream_core:init(0),
780776
C1 = rabbit_stream_SUITE:test_peer_properties(Transport, S, C0),
781777
C = rabbit_stream_SUITE:test_authenticate(Transport, S, C1),

deps/rabbitmq_web_mqtt/test/src/rfc6455_client.erl

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,9 @@ close(WS, WsReason) ->
103103
start_conn(State = #state{transport = Transport}, AuthInfo, Protocols, TcpPreface) ->
104104
{ok, Socket} = case TcpPreface of
105105
<<>> ->
106-
TlsOpts = case Transport of
107-
ssl -> [{verify, verify_none}];
108-
_ -> []
109-
end,
110106
Transport:connect(State#state.host, State#state.port,
111-
[binary, {packet, 0}] ++ TlsOpts);
107+
[binary,
108+
{packet, 0}]);
112109
_ ->
113110
{ok, Socket0} = gen_tcp:connect(State#state.host, State#state.port,
114111
[binary,

deps/rabbitmq_web_stomp/test/src/rfc6455_client.erl

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,9 @@ close(WS, WsReason) ->
8787
start_conn(State = #state{transport = Transport}, AuthInfo, Protocols, TcpPreface) ->
8888
{ok, Socket} = case TcpPreface of
8989
<<>> ->
90-
TlsOpts = case Transport of
91-
ssl -> [{verify, verify_none}];
92-
_ -> []
93-
end,
9490
Transport:connect(State#state.host, State#state.port,
95-
[binary, {packet, 0}] ++ TlsOpts);
91+
[binary,
92+
{packet, 0}]);
9693
_ ->
9794
{ok, Socket0} = gen_tcp:connect(State#state.host, State#state.port,
9895
[binary,

0 commit comments

Comments
 (0)