Skip to content

Commit 8a8230c

Browse files
Merge pull request #10446 from rabbitmq/rluvaton-add-to-ack-timeout-log-more-info-on-the-problematic-message
Improve the message logged when a channel runs into a consumer acknowledgement timeout
2 parents 507db36 + a188fbc commit 8a8230c

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

deps/rabbit/src/rabbit_channel.erl

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2780,13 +2780,15 @@ evaluate_consumer_timeout1(PA = #pending_ack{delivered_at = Time},
27802780
{noreply, State}
27812781
end.
27822782

2783-
handle_consumer_timed_out(Timeout,#pending_ack{delivery_tag = DeliveryTag},
2783+
handle_consumer_timed_out(Timeout,#pending_ack{delivery_tag = DeliveryTag, tag = ConsumerTag, queue = QName},
27842784
State = #ch{cfg = #conf{channel = Channel}}) ->
2785-
rabbit_log_channel:warning("Consumer ~ts on channel ~w has timed out "
2786-
"waiting for delivery acknowledgement. Timeout used: ~tp ms. "
2785+
rabbit_log_channel:warning("Consumer '~ts' on channel ~w and ~ts has timed out "
2786+
"waiting for a consumer acknowledgement of a delivery with delivery tag = ~b. Timeout used: ~tp ms. "
27872787
"This timeout value can be configured, see consumers doc guide to learn more",
2788-
[rabbit_data_coercion:to_binary(DeliveryTag),
2789-
Channel, Timeout]),
2788+
[ConsumerTag,
2789+
Channel,
2790+
rabbit_misc:rs(QName),
2791+
DeliveryTag, Timeout]),
27902792
Ex = rabbit_misc:amqp_error(precondition_failed,
27912793
"delivery acknowledgement on channel ~w timed out. "
27922794
"Timeout value used: ~tp ms. "

0 commit comments

Comments
 (0)